Pass instant from aptosdb for calculating latency metric #15678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areshand
requested review from
msmouse,
lightmark,
grao1991,
JoshLind,
banool,
gregnazario and
0xmaayan
as code owners
⏱️ 2h 10m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
msmouse
reviewed
Jan 6, 2025
ecosystem/indexer-grpc/indexer-grpc-table-info/src/internal_indexer_db_service.rs
Outdated
Show resolved
Hide resolved
areshand
force-pushed
the
pass_instant_latency
branch
3 times, most recently
from
0988f9c to
5f9b440
Compare
msmouse
reviewed
Jan 8, 2025
| @@ -166,31 +166,32 @@ impl InternalIndexerDBService { | |||
|
|
|||
| pub async fn run(&mut self, node_config: &NodeConfig) -> Result<()> { | |||
| let mut start_version = self.get_start_version(node_config).await?; | |||
| let mut target_version = self.db_indexer.main_db_reader.ensure_synced_version()?; | |||
There was a problem hiding this comment.
this will error out with an empty db (before genesis is put in), is that intentional?
There was a problem hiding this comment.
yes, internal indexer is supposed to start after main db bootstrapped.
ecosystem/indexer-grpc/indexer-grpc-table-info/src/internal_indexer_db_service.rs
Outdated
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-table-info/src/internal_indexer_db_service.rs
Outdated
Show resolved
Hide resolved
| log_grpc_step( | ||
| SERVICE_TYPE, | ||
| IndexerGrpcStep::InternalIndexerDBProcessed, | ||
| Some(start_version as i64), | ||
| Some(next_version as i64), | ||
| None, | ||
| None, | ||
| Some(start_time.elapsed().as_secs_f64()), | ||
| Some(step_timer.elapsed().as_secs_f64()), |
There was a problem hiding this comment.
same issue with yesterday, that before it's caught up you already logged the latency, which is not accurate?
There was a problem hiding this comment.
Each loop now is blocked on notification of write to main db. Previously, each loop is only a batch of all updates. so this should reflect the latency.
areshand
force-pushed
the
pass_instant_latency
branch
2 times, most recently
from
1db3ecd to
cc5d099
Compare
areshand
force-pushed
the
pass_instant_latency
branch
2 times, most recently
from
16ad465 to
072b5ff
Compare
msmouse
reviewed
Jan 14, 2025
| log_grpc_step( | ||
| SERVICE_TYPE, | ||
| IndexerGrpcStep::InternalIndexerDBProcessed, | ||
| Some(start_version as i64), | ||
| Some(next_version as i64), | ||
| None, | ||
| None, | ||
| Some(start_time.elapsed().as_secs_f64()), | ||
| Some(step_timer.elapsed().as_secs_f64()), |
| @@ -166,31 +166,32 @@ impl InternalIndexerDBService { | |||
|
|
|||
| pub async fn run(&mut self, node_config: &NodeConfig) -> Result<()> { | |||
| let mut start_version = self.get_start_version(node_config).await?; | |||
| let mut target_version = self.db_indexer.main_db_reader.ensure_synced_version()?; | |||
Comment on lines
+178
to
+180
| Err(e) => { | ||
| panic!("Failed to get update from update_receiver: {}", e); | ||
| }, |
There was a problem hiding this comment.
This is how this thread knows the main db has quit, right? In that case we should return Ok instead of suicide here?
And I realized even in the previous logic, this thread doesn't have a chance to quit until hitting the target version? It can be an issue when the first time the indexer is enabled? (granted we usually quit the maindb by killing the whole process, it'd be better if we deal with this case gracefully, if not too complicated.)
There was a problem hiding this comment.
- the DBindexer should have Arc of main_db. I expect the err should never be caused by main_db quit. (The main db quits after db indexer being dropped). Thus, I think it should panic if this unexpected error occurs.
- if the process is killed while the indexer is in the middle of processing a large amount of data. the thread is terminated the same way as other components reading main_db eg: API is reading transactions using storage interface and the node is killed.
There was a problem hiding this comment.
ugh, in that case the indexer loop never quits? That should be an issue in tests?
Shall we implement graceful quitting (separately)? @grao1991 ?
There was a problem hiding this comment.
there is a method called "run_with_end_version" for testing
msmouse
approved these changes
Jan 15, 2025
|
@grao1991 please take a look as well ? |
grao1991
approved these changes
Jan 16, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
areshand
force-pushed
the
pass_instant_latency
branch
from
4f6258c to
17b78fb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ Forge suite
|
❌ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist