Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external unique state and verified external value #15577

Draft
wants to merge 1 commit into
base: igor/object_delete_and_recreate
Choose a base branch
from

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 12, 2024

⏱️ 47m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
check-dynamic-deps 7m 🟩🟩🟩🟩🟩
rust-move-tests 5m 🟥
rust-move-tests 5m 🟥
rust-move-tests 5m 🟥
rust-lints 3m 🟥
rust-move-tests 3m 🟥
rust-move-tests 2m 🟥
general-lints 2m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
permission-check 21s 🟩🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Comment on lines +29 to +21
const ETYPE_MISMATCH: u64 = 4;
const EWITNESS_MISMATCH: u64 = 4;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error codes ETYPE_MISMATCH and EWITNESS_MISMATCH are both assigned the value 4. To maintain clear error handling and debugging, these should be given unique values. Consider assigning EWITNESS_MISMATCH a distinct error code, such as 5.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant