Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas schedule] add script to bump gas feature version #14983

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Oct 16, 2024

This adds a python script that can be used to bump LATEST_GAS_FEATURE_VERSION. It will also create the next gas feature version entry if it does not exist.

Sample output (after running the script 3 times):

diff --git a/aptos-move/aptos-gas-schedule/src/ver.rs b/aptos-move/aptos-gas-schedule/src/ver.rs
index 2c5ec6d504..31924b94a4 100644
--- a/aptos-move/aptos-gas-schedule/src/ver.rs
+++ b/aptos-move/aptos-gas-schedule/src/ver.rs
@@ -69,7 +69,7 @@
 ///       global operations.
 /// - V1
 ///   - TBA
-pub const LATEST_GAS_FEATURE_VERSION: u64 = gas_feature_versions::RELEASE_V1_22;
+pub const LATEST_GAS_FEATURE_VERSION: u64 = gas_feature_versions::RELEASE_V1_25;
 
 pub mod gas_feature_versions {
     pub const RELEASE_V1_8: u64 = 11;
@@ -89,4 +89,5 @@ pub mod gas_feature_versions {
     pub const RELEASE_V1_22: u64 = 26;
     pub const RELEASE_V1_23: u64 = 27;
     pub const RELEASE_V1_24: u64 = 28;
+    pub const RELEASE_V1_25: u64 = 29;
 }

Copy link

trunk-io bot commented Oct 16, 2024

⏱️ 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 9m 🟩
rust-move-tests 8m
rust-cargo-deny 4m 🟩🟩
check-dynamic-deps 2m 🟩🟩
general-lints 54s 🟩🟩
semgrep/ci 42s 🟩🟩
file_change_determinator 23s 🟩🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@vgao1996
Copy link
Contributor Author

vgao1996 commented Dec 3, 2024

@ibalajiarun @sherry-x @igor-aptos @perryjrandall guys, this has been stale for a while.

Shall we at least get the script checked in first, so later we can build the automation whenever we want?

@vgao1996 vgao1996 force-pushed the script-bump-gas-ver branch from bdff1d3 to 850d839 Compare January 7, 2025 23:32

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Forge suite realistic_env_max_load success on 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d

two traffics test: inner traffic : committed: 14781.82 txn/s, latency: 2690.45 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5620340
two traffics test : committed: 99.98 txn/s, latency: 1335.53 ms, (p50: 1300 ms, p70: 1400, p90: 1400 ms, p99: 2600 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.632, avg: 1.569", "ConsensusProposalToOrdered: max: 0.290, avg: 0.288", "ConsensusOrderedToCommit: max: 0.314, avg: 0.298", "ConsensusProposalToCommit: max: 0.600, avg: 0.586"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 1138 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 2404350 (avg 0.55s) [limit 16].
Test Ok

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 18808.37 txn/s, latency: 1870.60 ms, (p50: 1800 ms, p70: 2100, p90: 2100 ms, p99: 3900 ms), latency samples: 604480
2. Upgrading first Validator to new version: 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7635.17 txn/s, latency: 3749.74 ms, (p50: 3600 ms, p70: 4200, p90: 6300 ms, p99: 6500 ms), latency samples: 135260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8583.54 txn/s, latency: 3895.83 ms, (p50: 4200 ms, p70: 4300, p90: 4400 ms, p99: 4400 ms), latency samples: 284440
3. Upgrading rest of first batch to new version: 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 8185.66 txn/s, latency: 3626.24 ms, (p50: 4100 ms, p70: 4400, p90: 4600 ms, p99: 4600 ms), latency samples: 147940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 8024.40 txn/s, latency: 4167.76 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4800 ms), latency samples: 275460
4. upgrading second batch to new version: 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 14639.87 txn/s, latency: 1960.76 ms, (p50: 2200 ms, p70: 2300, p90: 2500 ms, p99: 2600 ms), latency samples: 251620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 14580.17 txn/s, latency: 2204.46 ms, (p50: 2300 ms, p70: 2400, p90: 2600 ms, p99: 3000 ms), latency samples: 467920
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 850d8395589bbd5ee9b7a1b73ecdf2d84a2cb76d passed
Test Ok

@vgao1996 vgao1996 merged commit a2479a6 into aptos-labs:main Jan 8, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants