Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump to 4.0.0 #14255

Merged
merged 1 commit into from
Aug 13, 2024
Merged

[cli] Bump to 4.0.0 #14255

merged 1 commit into from
Aug 13, 2024

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Aug 13, 2024

Description

Updated aptos crate version from 3.5.1 to 4.0.0 to include recent breaking changes with a new native function not being found.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Aug 13, 2024

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov marked this pull request as ready for review August 13, 2024 11:02
@georgemitenkov georgemitenkov enabled auto-merge (squash) August 13, 2024 16:36

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 7223.99 txn/s, latency: 3850.42 ms, (p50: 2700 ms, p90: 6300 ms, p99: 20100 ms), latency samples: 307800
2. Upgrading first Validator to new version: fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7498.67 txn/s, latency: 3629.00 ms, (p50: 3900 ms, p90: 5100 ms, p99: 5400 ms), latency samples: 132620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7380.22 txn/s, latency: 4264.99 ms, (p50: 4300 ms, p90: 6300 ms, p99: 6400 ms), latency samples: 247260
3. Upgrading rest of first batch to new version: fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6414.40 txn/s, latency: 4262.46 ms, (p50: 4600 ms, p90: 5800 ms, p99: 5900 ms), latency samples: 115160
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7240.39 txn/s, latency: 4368.49 ms, (p50: 4300 ms, p90: 6500 ms, p99: 7100 ms), latency samples: 244640
4. upgrading second batch to new version: fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8373.55 txn/s, latency: 3182.39 ms, (p50: 2800 ms, p90: 5000 ms, p99: 6400 ms), latency samples: 177080
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6533.48 txn/s, latency: 4554.38 ms, (p50: 3200 ms, p90: 7300 ms, p99: 16900 ms), latency samples: 255900
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2

two traffics test: inner traffic : committed: 11639.40 txn/s, latency: 3413.25 ms, (p50: 3300 ms, p90: 3900 ms, p99: 5100 ms), latency samples: 4425540
two traffics test : committed: 99.92 txn/s, latency: 2758.66 ms, (p50: 2700 ms, p90: 3100 ms, p99: 5500 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.241, avg: 0.226", "QsPosToProposal: max: 0.536, avg: 0.450", "ConsensusProposalToOrdered: max: 0.345, avg: 0.338", "ConsensusOrderedToCommit: max: 0.814, avg: 0.764", "ConsensusProposalToCommit: max: 1.151, avg: 1.102"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.03s no progress at version 2446549 (avg 0.24s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.83s no progress at version 2446547 (avg 7.83s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2 (PR)
Upgrade the nodes to version: fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 997.31 txn/s, submitted: 999.81 txn/s, failed submission: 2.50 txn/s, expired: 2.50 txn/s, latency: 3080.77 ms, (p50: 2400 ms, p90: 5100 ms, p99: 11500 ms), latency samples: 87740
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 978.63 txn/s, submitted: 980.64 txn/s, failed submission: 2.01 txn/s, expired: 2.01 txn/s, latency: 3219.10 ms, (p50: 2400 ms, p90: 5700 ms, p99: 13900 ms), latency samples: 87580
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2 passed
Upgrade the remaining nodes to version: fa39f3a8a1c949b0f4058c05a84b2522bdfc7ef2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1018.11 txn/s, submitted: 1019.95 txn/s, failed submission: 1.84 txn/s, expired: 1.84 txn/s, latency: 3109.88 ms, (p50: 2700 ms, p90: 5400 ms, p99: 8100 ms), latency samples: 88620
Test Ok

@georgemitenkov georgemitenkov merged commit f6e43ee into main Aug 13, 2024
88 checks passed
@georgemitenkov georgemitenkov deleted the george/cli-4.0.0 branch August 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants