Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TOO_MANY_DELAYED_FIELDS error code #12603

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

igor-aptos
Copy link
Contributor

Description

Type of Change

  • Bug fix

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine

How Has This Been Tested?

unit tests

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 20, 2024

⏱️ 7h 54m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 5m 🟥🟩
rust-smoke-tests 1h 1m 🟩🟩
windows-build 57m 🟩🟩🟩
execution-performance / single-node-performance 44m 🟩🟩
rust-move-tests 41m 🟥🟩
rust-move-unit-coverage 35m 🟩🟩
rust-images / rust-all 33m 🟩🟩
forge-compat-test / forge 29m 🟩🟩
forge-e2e-test / forge 29m 🟩🟩
rust-lints 23m 🟩🟩🟩
cli-e2e-tests / run-cli-tests 17m 🟩🟩
check 12m 🟩🟩🟩
run-tests-main-branch 11m 🟥🟥🟥
general-lints 6m 🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
file_change_determinator 26s 🟩🟩
execution-performance / file_change_determinator 18s 🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩
determine-docker-build-metadata 7s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-images / rust-all 19m 15m +23%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos enabled auto-merge (squash) March 20, 2024 00:55
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.0%. Comparing base (edf0650) to head (85c2356).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12603       +/-   ##
===========================================
- Coverage    69.9%    64.0%     -5.9%     
===========================================
  Files        2288      818     -1470     
  Lines      432602   181627   -250975     
===========================================
- Hits       302445   116377   -186068     
+ Misses     130157    65250    -64907     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/update_error_code branch from 0806b07 to 85c2356 Compare March 20, 2024 21:58

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 85c23564b534feff55f561da02f641426255f2bc

two traffics test: inner traffic : committed: 7331 txn/s, latency: 5344 ms, (p50: 5100 ms, p90: 6600 ms, p99: 10800 ms), latency samples: 3174700
two traffics test : committed: 100 txn/s, latency: 1827 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.216, avg: 0.201", "QsPosToProposal: max: 0.322, avg: 0.292", "ConsensusProposalToOrdered: max: 0.478, avg: 0.448", "ConsensusOrderedToCommit: max: 0.315, avg: 0.303", "ConsensusProposalToCommit: max: 0.778, avg: 0.751"]
Max round gap was 1 [limit 4] at version 1321459. Max no progress secs was 4.1912518 [limit 15] at version 1321459.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 85c23564b534feff55f561da02f641426255f2bc

Compatibility test results for aptos-node-v1.9.5 ==> 85c23564b534feff55f561da02f641426255f2bc (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 5947 txn/s, latency: 5535 ms, (p50: 4900 ms, p90: 8700 ms, p99: 15000 ms), latency samples: 208160
2. Upgrading first Validator to new version: 85c23564b534feff55f561da02f641426255f2bc
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 699 txn/s, latency: 33597 ms, (p50: 35000 ms, p90: 51500 ms, p99: 55700 ms), latency samples: 57320
3. Upgrading rest of first batch to new version: 85c23564b534feff55f561da02f641426255f2bc
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 375 txn/s, submitted: 566 txn/s, expired: 191 txn/s, latency: 35045 ms, (p50: 35600 ms, p90: 56500 ms, p99: 59400 ms), latency samples: 32693
4. upgrading second batch to new version: 85c23564b534feff55f561da02f641426255f2bc
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1925 txn/s, latency: 15375 ms, (p50: 18300 ms, p90: 19900 ms, p99: 20600 ms), latency samples: 90520
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 85c23564b534feff55f561da02f641426255f2bc passed
Test Ok

@igor-aptos igor-aptos merged commit e2fd0ba into main Mar 20, 2024
46 checks passed
@igor-aptos igor-aptos deleted the igor/update_error_code branch March 20, 2024 22:33
igor-aptos added a commit that referenced this pull request Mar 21, 2024
#12581) (#12594)

* Optimize BlockSTM memory usage for delayed fields (#12580)

This reduces memory footprint of amortized usage of delayed field with a single version from 3000 bytes to 600 bytes per delayed field.
Basically BTreeMap stores things in vectors of 5, and size of the value is large. This invalidates BTreeMap's cache optimization of storing them all together.

* Limit number of DelayedFields (aggregators) per resource

temporarily, until gas charges for aggregator loading are implemented, limit number of aggregators per resource

* Add a few counters for BlockSTM size (#12581)

* update TOO_MANY_DELAYED_FIELDS error code (#12603)

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants