-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TOO_MANY_DELAYED_FIELDS error code #12603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgemitenkov
approved these changes
Mar 20, 2024
vgao1996
approved these changes
Mar 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12603 +/- ##
===========================================
- Coverage 69.9% 64.0% -5.9%
===========================================
Files 2288 818 -1470
Lines 432602 181627 -250975
===========================================
- Hits 302445 116377 -186068
+ Misses 130157 65250 -64907 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
igor-aptos
force-pushed
the
igor/update_error_code
branch
from
March 20, 2024 21:58
0806b07
to
85c2356
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
igor-aptos
added a commit
that referenced
this pull request
Mar 20, 2024
igor-aptos
added a commit
that referenced
this pull request
Mar 21, 2024
#12581) (#12594) * Optimize BlockSTM memory usage for delayed fields (#12580) This reduces memory footprint of amortized usage of delayed field with a single version from 3000 bytes to 600 bytes per delayed field. Basically BTreeMap stores things in vectors of 5, and size of the value is large. This invalidates BTreeMap's cache optimization of storing them all together. * Limit number of DelayedFields (aggregators) per resource temporarily, until gas charges for aggregator loading are implemented, limit number of aggregators per resource * Add a few counters for BlockSTM size (#12581) * update TOO_MANY_DELAYED_FIELDS error code (#12603) ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
unit tests
Checklist