[Compiler-v2] Fix bug in assign_unpack_references #12575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 4h 42m total CI duration on this PR
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12575 +/- ##
===========================================
- Coverage 69.9% 64.0% -6.0%
===========================================
Files 2285 817 -1468
Lines 432040 181066 -250974
===========================================
- Hits 302391 115925 -186466
+ Misses 129649 65141 -64508 ☔ View full report in Codecov by Sentry. |
brmataptos
approved these changes
Mar 18, 2024
wrwg
reviewed
Mar 20, 2024
| @@ -1264,14 +1264,15 @@ impl<'env> Generator<'env> { | |||
| } else { | |||
| ReferenceKind::Mutable | |||
| }; | |||
| return self.gen_borrow_field_for_unpack_ref(id, str, arg, temps, ref_kind); | |||
| self.gen_borrow_field_for_unpack_ref(id, str, arg, temps, ref_kind); | |||
There was a problem hiding this comment.
Was the bug here really that the loop on 1276 wasn't run for this case?
There was a problem hiding this comment.
There are two issues, one is the loop wasn't run. The other one is that the type of struct pattern should be & instead of the struct type when unpacking a reference of a struct, which is fixed in the exp_builder.
wrwg
approved these changes
Mar 20, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug revealed in the test case
/simplifier-elimination/assign_unpack_references.moveby 1) changing the type of nodeId generated for the Unpack operation; 2) fixing a bug in the bytecode_generator to recursively handle struct pattern when the unpack target is reference.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
The fix can be validated by the output change in existing tests. Also added a transactional test
assign_unpack_references.Key Areas to Review
Checklist