Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add writable volume for the genesis.blob for Forge PFNs #12574

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Mar 18, 2024

Description

Fix an issue where Forge PFNs weren't able to start up because of a missing genesis.blob. There were some changes I made to the Volumes and VolumeMounts in #12524 that are also needed for PFNs

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Ran Forge for pfn_const_tps_with_realistic_env
https://github.com/aptos-labs/aptos-core/actions/runs/8332018633/job/22802583531

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Mar 18, 2024
Copy link

trunk-io bot commented Mar 18, 2024

@aluon aluon force-pushed the aluon/pfn-writable-genesis-vol branch from e59ae2c to e33aa90 Compare March 18, 2024 19:33
@aluon aluon requested review from msmouse, ibalajiarun, rustielin and a team March 18, 2024 20:06
Copy link
Contributor

@ibalajiarun ibalajiarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's make sure we run the pfn test on this PR before merging it.

@aluon
Copy link
Contributor Author

aluon commented Mar 18, 2024

I ran a a PFN test on this branch and it completed successfully https://github.com/aptos-labs/aptos-core/actions/runs/8332018633/job/22802583531

@aluon aluon enabled auto-merge (squash) March 18, 2024 20:23

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e33aa90005f4af06d61e3ef0bc413b2d17444e48

two traffics test: inner traffic : committed: 8142 txn/s, latency: 4815 ms, (p50: 4500 ms, p90: 5600 ms, p99: 9900 ms), latency samples: 3517380
two traffics test : committed: 100 txn/s, latency: 1864 ms, (p50: 1800 ms, p90: 2100 ms, p99: 3000 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.268, avg: 0.210", "QsPosToProposal: max: 0.245, avg: 0.229", "ConsensusProposalToOrdered: max: 0.488, avg: 0.436", "ConsensusOrderedToCommit: max: 0.319, avg: 0.301", "ConsensusProposalToCommit: max: 0.755, avg: 0.737"]
Max round gap was 1 [limit 4] at version 1698050. Max no progress secs was 4.468959 [limit 15] at version 1698050.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> e33aa90005f4af06d61e3ef0bc413b2d17444e48

Compatibility test results for aptos-node-v1.9.5 ==> e33aa90005f4af06d61e3ef0bc413b2d17444e48 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6836 txn/s, latency: 4856 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9600 ms), latency samples: 239280
2. Upgrading first Validator to new version: e33aa90005f4af06d61e3ef0bc413b2d17444e48
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 697 txn/s, latency: 35056 ms, (p50: 37900 ms, p90: 53400 ms, p99: 55300 ms), latency samples: 57160
3. Upgrading rest of first batch to new version: e33aa90005f4af06d61e3ef0bc413b2d17444e48
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 568 txn/s, submitted: 639 txn/s, expired: 70 txn/s, latency: 38026 ms, (p50: 37900 ms, p90: 57800 ms, p99: 59500 ms), latency samples: 42632
4. upgrading second batch to new version: e33aa90005f4af06d61e3ef0bc413b2d17444e48
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2610 txn/s, latency: 11317 ms, (p50: 11000 ms, p90: 18000 ms, p99: 18600 ms), latency samples: 125320
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> e33aa90005f4af06d61e3ef0bc413b2d17444e48 passed
Test Ok

@aluon aluon merged commit 6db7e27 into main Mar 18, 2024
80 checks passed
@aluon aluon deleted the aluon/pfn-writable-genesis-vol branch March 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants