-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add writable volume for the genesis.blob for Forge PFNs #12574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aluon
added
the
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
label
Mar 18, 2024
⏱️ 14h 30m total CI duration on this PR
|
aluon
force-pushed
the
aluon/pfn-writable-genesis-vol
branch
from
March 18, 2024 19:33
e59ae2c
to
e33aa90
Compare
ibalajiarun
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's make sure we run the pfn test on this PR before merging it.
rustielin
approved these changes
Mar 18, 2024
I ran a a PFN test on this branch and it completed successfully https://github.com/aptos-labs/aptos-core/actions/runs/8332018633/job/22802583531 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where Forge PFNs weren't able to start up because of a missing genesis.blob. There were some changes I made to the Volumes and VolumeMounts in #12524 that are also needed for PFNs
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Ran Forge for
pfn_const_tps_with_realistic_env
https://github.com/aptos-labs/aptos-core/actions/runs/8332018633/job/22802583531
Key Areas to Review
Checklist