Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vtxn todo in rosetta #12569

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix vtxn todo in rosetta #12569

merged 1 commit into from
Mar 18, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Mar 18, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 18, 2024

@zjma zjma marked this pull request as ready for review March 18, 2024 17:30
@zjma zjma enabled auto-merge (squash) March 18, 2024 17:31
@zjma zjma requested a review from gregnazario as a code owner March 18, 2024 17:32

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> d418122fabc7467aa43669c354512f6da02b0020

Compatibility test results for aptos-node-v1.9.5 ==> d418122fabc7467aa43669c354512f6da02b0020 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6914 txn/s, latency: 4856 ms, (p50: 5000 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 242020
2. Upgrading first Validator to new version: d418122fabc7467aa43669c354512f6da02b0020
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 746 txn/s, latency: 33246 ms, (p50: 36400 ms, p90: 52600 ms, p99: 53700 ms), latency samples: 59000
3. Upgrading rest of first batch to new version: d418122fabc7467aa43669c354512f6da02b0020
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 533 txn/s, submitted: 807 txn/s, expired: 273 txn/s, latency: 25570 ms, (p50: 18500 ms, p90: 53900 ms, p99: 60900 ms), latency samples: 41047
4. upgrading second batch to new version: d418122fabc7467aa43669c354512f6da02b0020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2998 txn/s, latency: 10084 ms, (p50: 12000 ms, p90: 14200 ms, p99: 15100 ms), latency samples: 131940
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> d418122fabc7467aa43669c354512f6da02b0020 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d418122fabc7467aa43669c354512f6da02b0020

two traffics test: inner traffic : committed: 8443 txn/s, latency: 4655 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 3639360
two traffics test : committed: 100 txn/s, latency: 1809 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2500 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.218, avg: 0.202", "QsPosToProposal: max: 0.259, avg: 0.235", "ConsensusProposalToOrdered: max: 0.475, avg: 0.401", "ConsensusOrderedToCommit: max: 0.296, avg: 0.280", "ConsensusProposalToCommit: max: 0.690, avg: 0.681"]
Max round gap was 1 [limit 4] at version 1437653. Max no progress secs was 4.362948 [limit 15] at version 1437653.
Test Ok

@zjma zjma merged commit c0363e3 into main Mar 18, 2024
80 checks passed
@zjma zjma deleted the zjma/vtxn-in-rosetta branch March 18, 2024 21:12
gregnazario pushed a commit to gregnazario/aptos-core that referenced this pull request Mar 18, 2024
gregnazario added a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants