-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Update processor dependency #12568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked on aptos-labs/aptos-indexer-processors#325. Update: Ready to roll. |
banool
force-pushed
the
banool/processor-dep-update
branch
2 times, most recently
from
March 21, 2024 08:40
515b2fe
to
c2ca38f
Compare
banool
changed the title
Update processor dep for CLI, update aptos-core deps accordingly
[CLI] Update processor dependency
Mar 21, 2024
banool
force-pushed
the
banool/processor-dep-update
branch
from
March 21, 2024 08:40
c2ca38f
to
c1d5f33
Compare
banool
force-pushed
the
banool/processor-dep-update
branch
from
March 21, 2024 18:06
c1d5f33
to
5964a81
Compare
gregnazario
approved these changes
Mar 21, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
larry-aptos
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update required more than just bumping the rev, a few things changed:
default-features = false
. See more here: Add support for using diesel async for migrations to avoid pq-sys dep aptos-indexer-processors#325.run_pending_migrations
takes in a generic DB object. To support this,run_migrations
was updated to useAsyncConnectionWrapper
since async connection itself doesn't impl the relevant traits. This required some changes to how we run migrations on our side.This PR has a secondary goal of making sure we're using an in-tree rev to avoid this problem: rust-lang/cargo#13555. The rev we depend on is in main of aptos-indexer-processors, it doesn't come from a branch.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Run a local testnet:
Run the TS SDK v2 tests against it:
Besides that, just CI.
Key Areas to Review
Ensure updating other deps won't cause issues.
Checklist