Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs. Add google as provider for devnet #12476

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Mar 12, 2024

Description

  1. Adds Google as the default OIDC provider on devnet.
  2. Fixes a small bug where ZKPs for an empty extra_field do not verify.
  3. Fixes the deserialization of JWTs for non OIDC standard claims

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Tested manually via the SDK by @heliuchuan and automatically by previous tests.

Key Areas to Review

None.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 12, 2024

⏱️ 13h 49m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 7h 30m 🟩🟩 (+2 more)
windows-build 2h 32m 🟩🟩🟩🟩🟩 (+3 more)
rust-lints 31m 🟥🟥🟩 (+2 more)
rust-smoke-tests 31m 🟩
run-tests-main-branch 29m 🟩🟩🟩🟩🟩 (+2 more)
check 24m 🟩🟩🟩 (+2 more)
execution-performance / single-node-performance 22m 🟩
rust-images / rust-all 21m 🟩
check-dynamic-deps 16m 🟩🟩🟩🟩🟩 (+3 more)
forge-e2e-test / forge 14m 🟩
general-lints 13m 🟩🟩🟩🟩 (+2 more)
forge-compat-test / forge 12m 🟩
cli-e2e-tests / run-cli-tests 6m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
permission-check 34s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 24s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 23s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 22s 🟩🟩🟩🟩 (+3 more)
file_change_determinator 16s 🟩
execution-performance / file_change_determinator 9s 🟩
permission-check 3s 🟩
determine-docker-build-metadata 3s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-images / rust-all 21m 15m +43%
rust-unit-tests 25m 31m -20%

settingsfeedbackdocs ⋅ learn more about trunk.io

@heliuchuan heliuchuan marked this pull request as ready for review March 12, 2024 17:17
@heliuchuan heliuchuan changed the title Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs. Add google as provider for devnet Mar 12, 2024
@heliuchuan heliuchuan enabled auto-merge (squash) March 13, 2024 00:07

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 7c2854aa2157215f91877734561b9651530d007d

Compatibility test results for aptos-node-v1.9.5 ==> 7c2854aa2157215f91877734561b9651530d007d (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6045 txn/s, latency: 5240 ms, (p50: 4800 ms, p90: 8700 ms, p99: 11100 ms), latency samples: 253900
2. Upgrading first Validator to new version: 7c2854aa2157215f91877734561b9651530d007d
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1243 txn/s, latency: 23170 ms, (p50: 24700 ms, p90: 31200 ms, p99: 34100 ms), latency samples: 64680
3. Upgrading rest of first batch to new version: 7c2854aa2157215f91877734561b9651530d007d
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 384 txn/s, submitted: 656 txn/s, expired: 272 txn/s, latency: 34300 ms, (p50: 33700 ms, p90: 51900 ms, p99: 55000 ms), latency samples: 28047
4. upgrading second batch to new version: 7c2854aa2157215f91877734561b9651530d007d
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2502 txn/s, latency: 11942 ms, (p50: 13600 ms, p90: 15000 ms, p99: 16000 ms), latency samples: 112600
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 7c2854aa2157215f91877734561b9651530d007d passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7c2854aa2157215f91877734561b9651530d007d

two traffics test: inner traffic : committed: 7679 txn/s, latency: 5114 ms, (p50: 5000 ms, p90: 6000 ms, p99: 10000 ms), latency samples: 3309940
two traffics test : committed: 100 txn/s, latency: 1858 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2500 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.228, avg: 0.203", "QsPosToProposal: max: 0.276, avg: 0.261", "ConsensusProposalToOrdered: max: 0.436, avg: 0.422", "ConsensusOrderedToCommit: max: 0.313, avg: 0.302", "ConsensusProposalToCommit: max: 0.736, avg: 0.724"]
Max round gap was 1 [limit 4] at version 1605957. Max no progress secs was 4.28724 [limit 15] at version 1605957.
Test Ok

@heliuchuan heliuchuan merged commit ee0d090 into aptos-labs:main Mar 13, 2024
70 checks passed
alinush pushed a commit that referenced this pull request Mar 20, 2024
…deserialization bugs. Add google as provider for devnet (#12476)

* fix bugs

* update

* add google as default provider for chain ids above 100

* fix

* use lazy

* remove unused deps

* lint
@alinush alinush mentioned this pull request Mar 20, 2024
21 tasks
alinush pushed a commit that referenced this pull request Mar 20, 2024
…deserialization bugs. Add google as provider for devnet (#12476)

* fix bugs

* update

* add google as default provider for chain ids above 100

* fix

* use lazy

* remove unused deps

* lint
alinush added a commit that referenced this pull request Mar 21, 2024
* Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs (#12476)

* [keyless] update feature gating & match alg field (#12521)


---------

Co-authored-by: Oliver He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants