-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs. Add google as provider for devnet #12476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliuchuan
changed the title
Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs
Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs. Add google as provider for devnet
Mar 12, 2024
alinush
reviewed
Mar 12, 2024
alinush
approved these changes
Mar 12, 2024
rex1fernando
approved these changes
Mar 12, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
alinush
pushed a commit
that referenced
this pull request
Mar 20, 2024
…deserialization bugs. Add google as provider for devnet (#12476) * fix bugs * update * add google as default provider for chain ids above 100 * fix * use lazy * remove unused deps * lint
21 tasks
alinush
pushed a commit
that referenced
this pull request
Mar 20, 2024
…deserialization bugs. Add google as provider for devnet (#12476) * fix bugs * update * add google as default provider for chain ids above 100 * fix * use lazy * remove unused deps * lint
alinush
added a commit
that referenced
this pull request
Mar 21, 2024
* Fix public_inputs_hash generation when extra_field not set and serde deserialization bugs (#12476) * [keyless] update feature gating & match alg field (#12521) --------- Co-authored-by: Oliver He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
devnet
.extra_field
do not verify.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Tested manually via the SDK by @heliuchuan and automatically by previous tests.
Key Areas to Review
None.
Checklist