Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INSUFFICIENT_BALANCE_FOR_TRANSACTION_FEE description #12439

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

igor-aptos
Copy link
Contributor

As far as I understand, INSUFFICIENT_BALANCE_FOR_TRANSACTION_FEE is thrown when accounts balance is not enough for the max_gas specified in the transaction. but current description is not conveying that, so trying to clarify it.

Is https://aptos.dev/reference/error-codes/ showing directly what is written here, or is there a separate change needed for that?

Description

Test Plan

Copy link

trunk-io bot commented Mar 8, 2024

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.9%. Comparing base (02d6c6f) to head (c18533e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12439       +/-   ##
===========================================
- Coverage    69.9%    63.9%     -6.0%     
===========================================
  Files        2269      803     -1466     
  Lines      427759   178107   -249652     
===========================================
- Hits       299321   113975   -185346     
+ Misses     128438    64132    -64306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igor-aptos igor-aptos enabled auto-merge (squash) March 8, 2024 23:44

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

✅ Forge suite compat success on aptos-node-v1.9.5 ==> c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3

Compatibility test results for aptos-node-v1.9.5 ==> c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6998 txn/s, latency: 4748 ms, (p50: 4800 ms, p90: 7400 ms, p99: 7900 ms), latency samples: 244960
2. Upgrading first Validator to new version: c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1544 txn/s, latency: 17812 ms, (p50: 17900 ms, p90: 22800 ms, p99: 23700 ms), latency samples: 80300
3. Upgrading rest of first batch to new version: c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 337 txn/s, submitted: 654 txn/s, expired: 317 txn/s, latency: 29879 ms, (p50: 32700 ms, p90: 49400 ms, p99: 68700 ms), latency samples: 24967
4. upgrading second batch to new version: c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1720 txn/s, latency: 17460 ms, (p50: 19300 ms, p90: 23500 ms, p99: 24700 ms), latency samples: 84300
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3 passed
Test Ok

Copy link
Contributor

github-actions bot commented Mar 9, 2024

✅ Forge suite realistic_env_max_load success on c18533eaf2f50e8ec7ddc96bb34e9cdcf4ea2ff3

two traffics test: inner traffic : committed: 7831 txn/s, latency: 5008 ms, (p50: 4800 ms, p90: 5700 ms, p99: 9900 ms), latency samples: 3383100
two traffics test : committed: 100 txn/s, latency: 1915 ms, (p50: 1800 ms, p90: 2100 ms, p99: 5300 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.259, avg: 0.206", "QsPosToProposal: max: 0.276, avg: 0.250", "ConsensusProposalToOrdered: max: 0.460, avg: 0.430", "ConsensusOrderedToCommit: max: 0.299, avg: 0.289", "ConsensusProposalToCommit: max: 0.734, avg: 0.719"]
Max round gap was 1 [limit 4] at version 1295573. Max no progress secs was 4.3141 [limit 15] at version 1295573.
Test Ok

@igor-aptos igor-aptos merged commit b68b4c8 into main Mar 9, 2024
82 of 83 checks passed
@igor-aptos igor-aptos deleted the igor/fix_insufficient_balance_text branch March 9, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants