Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude .exp files from whitespace checks in scripts/git-checks.sh #12359

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

brmataptos
Copy link
Contributor

@brmataptos brmataptos commented Mar 4, 2024

Description

In git-checks.sh, exclude whitespace checks for .exp files, which are program-generated and can have any syntax.

Test Plan

Tested locally with various previous commits involving extra whitespaces. Verified that .exp files are excluded, but others are not.

Fixes

#12356

@brmataptos brmataptos requested a review from a team as a code owner March 4, 2024 05:07
Copy link

trunk-io bot commented Mar 4, 2024

@brmataptos brmataptos changed the title exclude .exp files from whitespace checks exclude .exp files from whitespace checks in scripts/git-checks.sh Mar 4, 2024
@brmataptos brmataptos requested a review from wrwg March 4, 2024 05:07
@brmataptos brmataptos enabled auto-merge (squash) March 4, 2024 21:05

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 78aca67764d89a2160a03695668c762270401c51

Compatibility test results for aptos-node-v1.9.5 ==> 78aca67764d89a2160a03695668c762270401c51 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 5714 txn/s, latency: 5088 ms, (p50: 4800 ms, p90: 9300 ms, p99: 10200 ms), latency samples: 228580
2. Upgrading first Validator to new version: 78aca67764d89a2160a03695668c762270401c51
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 690 txn/s, latency: 33969 ms, (p50: 35600 ms, p90: 53200 ms, p99: 56000 ms), latency samples: 57280
3. Upgrading rest of first batch to new version: 78aca67764d89a2160a03695668c762270401c51
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 326 txn/s, submitted: 672 txn/s, expired: 346 txn/s, latency: 32542 ms, (p50: 40100 ms, p90: 48500 ms, p99: 57000 ms), latency samples: 23156
4. upgrading second batch to new version: 78aca67764d89a2160a03695668c762270401c51
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2227 txn/s, latency: 13454 ms, (p50: 14300 ms, p90: 16000 ms, p99: 16900 ms), latency samples: 100220
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 78aca67764d89a2160a03695668c762270401c51 passed
Test Ok

Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Forge suite realistic_env_max_load success on 78aca67764d89a2160a03695668c762270401c51

two traffics test: inner traffic : committed: 7405 txn/s, latency: 5284 ms, (p50: 5100 ms, p90: 6300 ms, p99: 13500 ms), latency samples: 3206540
two traffics test : committed: 100 txn/s, latency: 1989 ms, (p50: 1800 ms, p90: 2100 ms, p99: 8800 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.232, avg: 0.202", "QsPosToProposal: max: 0.367, avg: 0.287", "ConsensusProposalToOrdered: max: 0.480, avg: 0.444", "ConsensusOrderedToCommit: max: 0.332, avg: 0.302", "ConsensusProposalToCommit: max: 0.778, avg: 0.746"]
Max round gap was 1 [limit 4] at version 2535. Max no progress secs was 4.200217 [limit 15] at version 1951370.
Test Ok

@brmataptos brmataptos merged commit 3023c2b into main Mar 4, 2024
80 checks passed
@brmataptos brmataptos deleted the brm-issue-12356 branch March 4, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants