Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use async sleep in pepper #12344

Merged
merged 2 commits into from
Mar 2, 2024
Merged

use async sleep in pepper #12344

merged 2 commits into from
Mar 2, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Mar 2, 2024

Description

Test Plan

Copy link

trunk-io bot commented Mar 2, 2024

⏱️ 6h 9m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-smoke-tests 1h 38m 🟩
rust-lints 1h 17m 🟥🟩
windows-build 51m 🟩🟩🟩
rust-unit-tests 41m 🟩
execution-performance / single-node-performance 21m 🟩
rust-images / rust-all 14m 🟩
forge-compat-test / forge 13m 🟩
forge-e2e-test / forge 13m 🟩
run-tests-main-branch 10m 🟩🟩
check 10m 🟩🟩
cli-e2e-tests / run-cli-tests 6m 🟩
check-dynamic-deps 6m 🟩🟩🟩
general-lints 5m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 50s 🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
execution-performance / file_change_determinator 15s 🟩
file_change_determinator 12s 🟩
permission-check 10s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
permission-check 5s 🟩
determine-docker-build-metadata 3s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 1h 12m 8m +828%
rust-smoke-tests 1h 38m 31m +217%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@geekflyer geekflyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also remove the unused thread::sleep import plz?

@zjma zjma marked this pull request as ready for review March 2, 2024 02:09
@zjma zjma enabled auto-merge (squash) March 2, 2024 02:10

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

✅ Forge suite realistic_env_max_load success on 6eeac1df6cbc2c0311bfc782bef4fccf8965f765

two traffics test: inner traffic : committed: 7358 txn/s, latency: 5296 ms, (p50: 5100 ms, p90: 6300 ms, p99: 10200 ms), latency samples: 3201160
two traffics test : committed: 100 txn/s, latency: 1883 ms, (p50: 1800 ms, p90: 2100 ms, p99: 5700 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.217, avg: 0.201", "QsPosToProposal: max: 0.355, avg: 0.323", "ConsensusProposalToOrdered: max: 0.483, avg: 0.450", "ConsensusOrderedToCommit: max: 0.314, avg: 0.296", "ConsensusProposalToCommit: max: 0.756, avg: 0.746"]
Max round gap was 1 [limit 4] at version 1511250. Max no progress secs was 3.969742 [limit 15] at version 1511250.
Test Ok

Copy link
Contributor

github-actions bot commented Mar 2, 2024

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 6eeac1df6cbc2c0311bfc782bef4fccf8965f765

Compatibility test results for aptos-node-v1.9.5 ==> 6eeac1df6cbc2c0311bfc782bef4fccf8965f765 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6780 txn/s, latency: 4891 ms, (p50: 4800 ms, p90: 8800 ms, p99: 9300 ms), latency samples: 237300
2. Upgrading first Validator to new version: 6eeac1df6cbc2c0311bfc782bef4fccf8965f765
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 683 txn/s, latency: 35141 ms, (p50: 38100 ms, p90: 54600 ms, p99: 58200 ms), latency samples: 57380
3. Upgrading rest of first batch to new version: 6eeac1df6cbc2c0311bfc782bef4fccf8965f765
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 132 txn/s, submitted: 647 txn/s, expired: 514 txn/s, latency: 26161 ms, (p50: 9500 ms, p90: 53800 ms, p99: 54000 ms), latency samples: 8871
4. upgrading second batch to new version: 6eeac1df6cbc2c0311bfc782bef4fccf8965f765
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2431 txn/s, latency: 12402 ms, (p50: 11700 ms, p90: 18700 ms, p99: 19000 ms), latency samples: 114280
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 6eeac1df6cbc2c0311bfc782bef4fccf8965f765 passed
Test Ok

@zjma zjma merged commit f0ba79d into main Mar 2, 2024
77 of 80 checks passed
@zjma zjma deleted the zjma/fix_pepper_sleep branch March 2, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants