-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests for keyless feature gating #12296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinush
requested review from
rex1fernando,
heliuchuan,
mstraka100 and
zekun000
February 29, 2024 04:03
alinush
requested review from
davidiw,
wrwg,
vgao1996 and
georgemitenkov
as code owners
February 29, 2024 04:03
alinush
force-pushed
the
alin/feature-gating-keyless
branch
from
February 29, 2024 04:38
0bba2e8
to
5437a7f
Compare
heliuchuan
approved these changes
Feb 29, 2024
alinush
force-pushed
the
alin/feature-gating-keyless
branch
from
February 29, 2024 19:16
5437a7f
to
1eff98b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12296 +/- ##
=========================================
- Coverage 64.1% 64.0% -0.1%
=========================================
Files 794 794
Lines 176445 176612 +167
=========================================
Hits 113195 113195
- Misses 63250 63417 +167 ☔ View full report in Codecov by Sentry. |
alinush
force-pushed
the
alin/feature-gating-keyless
branch
2 times, most recently
from
February 29, 2024 23:32
3f8335f
to
5c110d8
Compare
alinush
force-pushed
the
alin/feature-gating-keyless
branch
2 times, most recently
from
March 1, 2024 19:16
3414729
to
f50cb63
Compare
alinush
force-pushed
the
alin/feature-gating-keyless
branch
from
March 1, 2024 19:22
f50cb63
to
5201ae4
Compare
alinush
changed the title
clearer feature gating for keyless TXNs
e2e tests for keyless feature gating
Mar 1, 2024
mstraka100
approved these changes
Mar 1, 2024
alinush
force-pushed
the
alin/feature-gating-keyless
branch
from
March 1, 2024 19:50
8cbc6d3
to
9deead1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
alinush
added a commit
that referenced
this pull request
Mar 4, 2024
alinush
added a commit
that referenced
this pull request
Mar 4, 2024
alinush
added a commit
that referenced
this pull request
Mar 4, 2024
* Add custom Serialize/Deserialize impl for EphemeralPublicKey, Pepper, Groth16ZkpAndStatement, G1Bytes, and G2Bytes, which output hex when used to serialize json (#12295) * e2e Move tests for keyless + feature gating (#12296) * add support for passkey-based EPKs & merge non-malleability signature into ephemeral signature (#12333) Co-authored-by: Rex Fernando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
AptosVM::validate_signed_transaction
e2e-move-tests
MoveHarness
to work with keyless accounts, not just Ed25519 accounts