Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFT Metadata Crawler] Remove null bytes #12264

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

just-in-chang
Copy link
Contributor

Description

Addressing this error
image

Code copied from processors repo

Test Plan

Locally

Copy link

trunk-io bot commented Feb 27, 2024

⏱️ 12h 31m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 27m 🟩
rust-smoke-coverage 3h 11m 🟩
windows-build 1h 3m 🟩🟩🟩
rust-unit-tests 1h 2m 🟩🟩
rust-images / rust-all 32m 🟩🟩
rust-smoke-tests 28m 🟩
execution-performance / single-node-performance 20m 🟩
rust-lints 16m 🟩🟩
run-tests-main-branch 14m 🟥🟥
forge-e2e-test / forge 14m 🟩
forge-compat-test / forge 12m 🟩
check 10m 🟩🟩
check-dynamic-deps 6m 🟩🟩🟩
general-lints 6m 🟩🟩
cli-e2e-tests / run-cli-tests 6m 🟩
semgrep/ci 1m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
file_change_determinator 31s 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
file_change_determinator 21s 🟩🟩
permission-check 16s 🟩🟩🟩
upload-to-codecov 16s 🟩
permission-check 12s 🟩🟩🟩
permission-check 11s 🟩🟩🟩
execution-performance / file_change_determinator 9s 🟩
permission-check 8s 🟩🟩
permission-check 8s 🟩🟩🟩
determine-docker-build-metadata 5s 🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +67%
rust-images / rust-all 20m 14m +38%
windows-build 25m 20m +25%

settingsfeedbackdocs ⋅ learn more about trunk.io

@just-in-chang just-in-chang requested review from bowenyang007 and a team February 27, 2024 20:45
@just-in-chang just-in-chang added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Feb 27, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 70.0%. Comparing base (2a1db6f) to head (df7ab8b).
Report is 3 commits behind head on main.

Files Patch % Lines
...cosystem/nft-metadata-crawler-parser/src/config.rs 0.0% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12264       +/-   ##
===========================================
+ Coverage    64.1%    70.0%     +5.8%     
===========================================
  Files         792     2239     +1447     
  Lines      176059   422339   +246280     
===========================================
+ Hits       112994   295722   +182728     
- Misses      63065   126617    +63552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-in-chang just-in-chang enabled auto-merge (squash) February 28, 2024 23:56

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> df7ab8b715dc69a362b9c2a43ccddadf5c3a478e

Compatibility test results for aptos-node-v1.9.5 ==> df7ab8b715dc69a362b9c2a43ccddadf5c3a478e (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6532 txn/s, latency: 5069 ms, (p50: 4800 ms, p90: 8700 ms, p99: 11600 ms), latency samples: 228640
2. Upgrading first Validator to new version: df7ab8b715dc69a362b9c2a43ccddadf5c3a478e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 699 txn/s, latency: 35139 ms, (p50: 39200 ms, p90: 54800 ms, p99: 57300 ms), latency samples: 58020
3. Upgrading rest of first batch to new version: df7ab8b715dc69a362b9c2a43ccddadf5c3a478e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 309 txn/s, submitted: 574 txn/s, expired: 265 txn/s, latency: 45904 ms, (p50: 48800 ms, p90: 54100 ms, p99: 57100 ms), latency samples: 21674
4. upgrading second batch to new version: df7ab8b715dc69a362b9c2a43ccddadf5c3a478e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2224 txn/s, latency: 13291 ms, (p50: 14700 ms, p90: 15600 ms, p99: 16700 ms), latency samples: 100120
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> df7ab8b715dc69a362b9c2a43ccddadf5c3a478e passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on df7ab8b715dc69a362b9c2a43ccddadf5c3a478e

two traffics test: inner traffic : committed: 7483 txn/s, latency: 5241 ms, (p50: 5100 ms, p90: 6000 ms, p99: 11700 ms), latency samples: 3233040
two traffics test : committed: 100 txn/s, latency: 1859 ms, (p50: 1800 ms, p90: 2000 ms, p99: 7300 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.254, avg: 0.206", "QsPosToProposal: max: 0.327, avg: 0.272", "ConsensusProposalToOrdered: max: 0.491, avg: 0.442", "ConsensusOrderedToCommit: max: 0.317, avg: 0.297", "ConsensusProposalToCommit: max: 0.765, avg: 0.739"]
Max round gap was 1 [limit 4] at version 12569. Max no progress secs was 3.830875 [limit 15] at version 1508270.
Test Ok

@just-in-chang just-in-chang merged commit faeb454 into main Feb 29, 2024
120 of 123 checks passed
@just-in-chang just-in-chang deleted the justin/remove-null branch February 29, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants