Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor][compiler-v2] Move lone test out of no-safety #12248

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

vineethk
Copy link
Contributor

Description

There was one transactional test in no-safety, which can now be moved out because we can successfully run safety checks on it.

Test Plan

Enables safety checks on the transactional test simple_map_keys.move. Everything else remains the same.

Copy link

trunk-io bot commented Feb 27, 2024

@vineethk vineethk enabled auto-merge (squash) February 27, 2024 18:44

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.1%. Comparing base (76e2c37) to head (3ff626b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12248   +/-   ##
=======================================
  Coverage    64.1%    64.1%           
=======================================
  Files         792      792           
  Lines      176059   176059           
=======================================
  Hits       112994   112994           
  Misses      63065    63065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 3ff626b94bda8b5632f4be10963d5d6a89555260

Compatibility test results for aptos-node-v1.9.5 ==> 3ff626b94bda8b5632f4be10963d5d6a89555260 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6644 txn/s, latency: 4964 ms, (p50: 4800 ms, p90: 8200 ms, p99: 9800 ms), latency samples: 232540
2. Upgrading first Validator to new version: 3ff626b94bda8b5632f4be10963d5d6a89555260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 714 txn/s, latency: 34005 ms, (p50: 35300 ms, p90: 52700 ms, p99: 54500 ms), latency samples: 57140
3. Upgrading rest of first batch to new version: 3ff626b94bda8b5632f4be10963d5d6a89555260
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 339 txn/s, submitted: 554 txn/s, expired: 215 txn/s, latency: 37976 ms, (p50: 35900 ms, p90: 54500 ms, p99: 57300 ms), latency samples: 29167
4. upgrading second batch to new version: 3ff626b94bda8b5632f4be10963d5d6a89555260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2297 txn/s, latency: 12715 ms, (p50: 12400 ms, p90: 17200 ms, p99: 18000 ms), latency samples: 110280
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 3ff626b94bda8b5632f4be10963d5d6a89555260 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 3ff626b94bda8b5632f4be10963d5d6a89555260

two traffics test: inner traffic : committed: 7459 txn/s, latency: 5262 ms, (p50: 5100 ms, p90: 6500 ms, p99: 10400 ms), latency samples: 3214840
two traffics test : committed: 100 txn/s, latency: 1832 ms, (p50: 1800 ms, p90: 2100 ms, p99: 3000 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.258, avg: 0.206", "QsPosToProposal: max: 0.291, avg: 0.266", "ConsensusProposalToOrdered: max: 0.470, avg: 0.446", "ConsensusOrderedToCommit: max: 0.292, avg: 0.281", "ConsensusProposalToCommit: max: 0.742, avg: 0.727"]
Max round gap was 1 [limit 4] at version 632619. Max no progress secs was 4.083188 [limit 15] at version 2976165.
Test Ok

@vineethk vineethk merged commit 2a1db6f into main Feb 27, 2024
77 of 83 checks passed
@vineethk vineethk deleted the vk/minor-move-test branch February 27, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants