Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting forge changes #12236

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Reverting forge changes #12236

merged 1 commit into from
Feb 26, 2024

Conversation

vusirikala
Copy link
Contributor

Description

Reverting forge changes.

Copy link

trunk-io bot commented Feb 26, 2024

⏱️ 3h 8m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 57m 🟩🟩
rust-smoke-tests 31m 🟩
rust-unit-tests 30m 🟩
rust-images / rust-all 19m 🟩
execution-performance / single-node-performance 18m 🟩
forge-e2e-test / forge 14m 🟩
forge-compat-test / forge 13m 🟩
cli-e2e-tests / run-cli-tests 6m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 53s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
windows-build 30m 20m +51%
rust-images / rust-all 19m 14m +33%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vusirikala vusirikala enabled auto-merge (squash) February 26, 2024 20:10

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86

Compatibility test results for aptos-node-v1.9.5 ==> 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6939 txn/s, latency: 4805 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 242880
2. Upgrading first Validator to new version: 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 779 txn/s, latency: 33702 ms, (p50: 36400 ms, p90: 53400 ms, p99: 55600 ms), latency samples: 56140
3. Upgrading rest of first batch to new version: 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 302 txn/s, submitted: 600 txn/s, expired: 298 txn/s, latency: 25790 ms, (p50: 24100 ms, p90: 47700 ms, p99: 62200 ms), latency samples: 26026
4. upgrading second batch to new version: 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2114 txn/s, latency: 13577 ms, (p50: 13800 ms, p90: 16800 ms, p99: 17500 ms), latency samples: 99380
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 77d69b3a1bb2d6b5b50f1588d90bc923cfe28d86

two traffics test: inner traffic : committed: 7638 txn/s, latency: 5123 ms, (p50: 4900 ms, p90: 6000 ms, p99: 11600 ms), latency samples: 3307460
two traffics test : committed: 100 txn/s, latency: 2011 ms, (p50: 1800 ms, p90: 2000 ms, p99: 9000 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.276, avg: 0.208", "QsPosToProposal: max: 0.325, avg: 0.289", "ConsensusProposalToOrdered: max: 0.493, avg: 0.438", "ConsensusOrderedToCommit: max: 0.313, avg: 0.289", "ConsensusProposalToCommit: max: 0.776, avg: 0.727"]
Max round gap was 1 [limit 4] at version 1588572. Max no progress secs was 4.213894 [limit 15] at version 1588572.
Test Ok

@vusirikala vusirikala merged commit ebdb359 into main Feb 26, 2024
61 of 80 checks passed
@vusirikala vusirikala deleted the satya/revert-forge branch February 26, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants