Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Force global config file #12180

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

gregnazario
Copy link
Contributor

Description

Right now, we can't change the default on the global config, because no one has a file to fall back on. So, this forces the file to show up, and then we can change the default afterwards.

Test Plan

Right now, we can't change the default on the global config, because
no one has a file to fall back on.  So, this forces the file to show
up, and then we can change the default afterwards.
@gregnazario gregnazario requested a review from banool as a code owner February 22, 2024 23:57
Copy link

trunk-io bot commented Feb 22, 2024

Ok(GlobalConfig::default())
// Let's create the file if it doesn't exist
let config = GlobalConfig::default();
config.save()?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that this may fail for permissions reasons. I can think of some situations where that might indeed happen. So maybe this should be best effort?

@gregnazario gregnazario enabled auto-merge (squash) February 27, 2024 18:58

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> b6a78bc059a68706261193303e00711da86da733

Compatibility test results for aptos-node-v1.9.5 ==> b6a78bc059a68706261193303e00711da86da733 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6616 txn/s, latency: 4836 ms, (p50: 4800 ms, p90: 5400 ms, p99: 8100 ms), latency samples: 251420
2. Upgrading first Validator to new version: b6a78bc059a68706261193303e00711da86da733
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 925 txn/s, latency: 29981 ms, (p50: 35900 ms, p90: 42900 ms, p99: 44900 ms), latency samples: 56460
3. Upgrading rest of first batch to new version: b6a78bc059a68706261193303e00711da86da733
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 421 txn/s, submitted: 649 txn/s, expired: 228 txn/s, latency: 32549 ms, (p50: 32300 ms, p90: 57900 ms, p99: 68900 ms), latency samples: 37918
4. upgrading second batch to new version: b6a78bc059a68706261193303e00711da86da733
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2919 txn/s, latency: 10506 ms, (p50: 9800 ms, p90: 17800 ms, p99: 18400 ms), latency samples: 134280
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> b6a78bc059a68706261193303e00711da86da733 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b6a78bc059a68706261193303e00711da86da733

two traffics test: inner traffic : committed: 7158 txn/s, latency: 5474 ms, (p50: 5100 ms, p90: 7200 ms, p99: 12300 ms), latency samples: 3099600
two traffics test : committed: 100 txn/s, latency: 2031 ms, (p50: 1900 ms, p90: 2200 ms, p99: 6100 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.229, avg: 0.203", "QsPosToProposal: max: 0.437, avg: 0.250", "ConsensusProposalToOrdered: max: 0.567, avg: 0.535", "ConsensusOrderedToCommit: max: 0.348, avg: 0.333", "ConsensusProposalToCommit: max: 0.891, avg: 0.868"]
Max round gap was 1 [limit 4] at version 1486663. Max no progress secs was 4.000021 [limit 15] at version 1486663.
Test Ok

@gregnazario gregnazario merged commit 7d67a78 into aptos-labs:main Feb 27, 2024
77 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants