Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics + logs of proposed vtxn count & size #12164

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 22, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 22, 2024

@zjma zjma marked this pull request as ready for review February 22, 2024 07:37
@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 22, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> ba39f651da52f3ace4dad20bdeb03bdf388310dc

Compatibility test results for aptos-node-v1.9.5 ==> ba39f651da52f3ace4dad20bdeb03bdf388310dc (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6705 txn/s, latency: 4993 ms, (p50: 4800 ms, p90: 8900 ms, p99: 9900 ms), latency samples: 234680
2. Upgrading first Validator to new version: ba39f651da52f3ace4dad20bdeb03bdf388310dc
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 643 txn/s, submitted: 659 txn/s, expired: 15 txn/s, latency: 36882 ms, (p50: 38700 ms, p90: 58800 ms, p99: 60000 ms), latency samples: 56019
3. Upgrading rest of first batch to new version: ba39f651da52f3ace4dad20bdeb03bdf388310dc
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 208 txn/s, submitted: 542 txn/s, expired: 334 txn/s, latency: 38507 ms, (p50: 40100 ms, p90: 53400 ms, p99: 60400 ms), latency samples: 17276
4. upgrading second batch to new version: ba39f651da52f3ace4dad20bdeb03bdf388310dc
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2342 txn/s, latency: 12588 ms, (p50: 12300 ms, p90: 17800 ms, p99: 18700 ms), latency samples: 112420
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> ba39f651da52f3ace4dad20bdeb03bdf388310dc passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ba39f651da52f3ace4dad20bdeb03bdf388310dc

two traffics test: inner traffic : committed: 6933 txn/s, latency: 5620 ms, (p50: 5400 ms, p90: 7200 ms, p99: 10500 ms), latency samples: 3016040
two traffics test : committed: 100 txn/s, latency: 2137 ms, (p50: 2100 ms, p90: 2400 ms, p99: 3000 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.239, avg: 0.203", "QsPosToProposal: max: 0.579, avg: 0.510", "ConsensusProposalToOrdered: max: 0.616, avg: 0.577", "ConsensusOrderedToCommit: max: 0.446, avg: 0.416", "ConsensusProposalToCommit: max: 1.014, avg: 0.993"]
Max round gap was 1 [limit 4] at version 1409578. Max no progress secs was 3.893413 [limit 15] at version 1409578.
Test Ok

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d69d3c1) 70.2% compared to head (ba39f65) 69.9%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12164       +/-   ##
===========================================
- Coverage    70.2%    69.9%     -0.4%     
===========================================
  Files         850     2237     +1387     
  Lines      189123   421333   +232210     
===========================================
+ Hits       132950   294829   +161879     
- Misses      56173   126504    +70331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-aptos pr-aptos self-assigned this Feb 23, 2024
@zjma zjma merged commit fd14f57 into main Feb 23, 2024
80 of 85 checks passed
@zjma zjma deleted the zjma/vtxn_proposed_metrics branch February 23, 2024 00:43
zjma added a commit that referenced this pull request Feb 29, 2024
zjma added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants