-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] Improve platform handling, fix faucet tests #12161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
added
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
CICD:experimental-forge
CICD:experimental-build
CICD:non-required-tests
If this label is present, non-required tests will be run on the PR.
and removed
CICD:experimental-forge
labels
Feb 22, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
banool
force-pushed
the
banool/fix-cli-e2e-tests
branch
from
February 22, 2024 07:42
de013b9
to
1050d74
Compare
banool
changed the title
[E2E] Improve platform handling
[E2E] Improve platform handling, fix faucet and faucet tests
Feb 22, 2024
banool
force-pushed
the
banool/fix-cli-e2e-tests
branch
from
February 22, 2024 07:49
1050d74
to
9f487ad
Compare
banool
force-pushed
the
banool/fix-cli-e2e-tests
branch
from
February 22, 2024 07:57
9f487ad
to
e072140
Compare
banool
changed the title
[E2E] Improve platform handling, fix faucet and faucet tests
[E2E] Improve platform handling, fix faucet tests
Feb 22, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12161 +/- ##
===========================================
- Coverage 70.2% 70.0% -0.3%
===========================================
Files 850 2237 +1387
Lines 189123 421307 +232184
===========================================
+ Hits 132950 295058 +162108
- Misses 56173 126249 +70076 ☔ View full report in Codecov by Sentry. |
perryjrandall
approved these changes
Feb 22, 2024
JoshLind
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:experimental-build
CICD:non-required-tests
If this label is present, non-required tests will be run on the PR.
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve platform handling in the faucet and CLI e2e tests so you don't have to worry about the docker platform env vars.
Beyond that, I fixed the faucet CI in two ways:
Test Plan
I changed pull_request_target to pull_request temporarily to confirm that this worked: https://github.com/aptos-labs/aptos-core/actions/runs/8001108730/job/21851689189?pr=12161.
The faucet tests are legit and are meant to be reliable signal that something breaks faucet compatibility, so I will make them land blocking after this change lands and looks good for a bit.
This compiles now: