Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible proto chagne. #12016

Merged
merged 5 commits into from
Feb 14, 2024
Merged

make compatible proto chagne. #12016

merged 5 commits into from
Feb 14, 2024

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Feb 14, 2024

Description

  • This change renames the newly added field signature to signature_variant to avoid removal of existing field.

    • Otherwise, the old processors might crash.
  • Note: the ts/py generated code will be in a different PR.

Test Plan

  • Linter

  • Locally tested with cache worker and file worker looks good.

image

Copy link

trunk-io bot commented Feb 14, 2024

⏱️ 7h 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 43m 🟩🟩 (+2 more)
windows-build 1h 42m 🟥🟩🟩🟩🟩 (+2 more)
rust-lints 39m 🟩🟩🟩 (+2 more)
rust-smoke-tests 30m 🟩
run-tests-main-branch 27m 🟥🟥🟥🟥🟥 (+2 more)
check 21m 🟥🟥🟥🟥🟥 (+2 more)
execution-performance / single-node-performance 19m 🟩
general-lints 17m 🟩🟩🟩🟩🟩 (+2 more)
check-dynamic-deps 14m 🟩🟩🟩🟩🟩 (+2 more)
forge-e2e-test / forge 14m 🟩
rust-images / rust-all 12m 🟩
forge-compat-test / forge 12m 🟩
cli-e2e-tests / run-cli-tests 9m 🟥
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
node-api-compatibility-tests / node-api-compatibility-tests 53s 🟩
permission-check 21s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 20s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 20s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 9s 🟩
execution-performance / file_change_determinator 9s 🟩
permission-check 2s 🟩
determine-docker-build-metadata 1s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 9m 7m +32%
windows-build 11m 18m -37%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rtso
Copy link
Contributor

rtso commented Feb 14, 2024

can you update the test plan?

@larry-aptos
Copy link
Contributor Author

can you update the test plan?

done

@larry-aptos larry-aptos enabled auto-merge (squash) February 14, 2024 21:33

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> c7b8e1da15e9ed38c3c9e48d3927940f2e058c91

Compatibility test results for aptos-node-v1.8.3 ==> c7b8e1da15e9ed38c3c9e48d3927940f2e058c91 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4947 txn/s, latency: 6632 ms, (p50: 6600 ms, p90: 9900 ms, p99: 14200 ms), latency samples: 183060
2. Upgrading first Validator to new version: c7b8e1da15e9ed38c3c9e48d3927940f2e058c91
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1784 txn/s, latency: 16123 ms, (p50: 19300 ms, p90: 22200 ms, p99: 22600 ms), latency samples: 92800
3. Upgrading rest of first batch to new version: c7b8e1da15e9ed38c3c9e48d3927940f2e058c91
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1504 txn/s, latency: 18857 ms, (p50: 19500 ms, p90: 23200 ms, p99: 24600 ms), latency samples: 76740
4. upgrading second batch to new version: c7b8e1da15e9ed38c3c9e48d3927940f2e058c91
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3089 txn/s, latency: 10090 ms, (p50: 9600 ms, p90: 19700 ms, p99: 20800 ms), latency samples: 123580
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> c7b8e1da15e9ed38c3c9e48d3927940f2e058c91 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c7b8e1da15e9ed38c3c9e48d3927940f2e058c91

two traffics test: inner traffic : committed: 7627 txn/s, latency: 5023 ms, (p50: 4500 ms, p90: 6100 ms, p99: 12900 ms), latency samples: 3287300
two traffics test : committed: 100 txn/s, latency: 2368 ms, (p50: 2100 ms, p90: 2400 ms, p99: 12100 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.277, avg: 0.214", "QsPosToProposal: max: 0.155, avg: 0.147", "ConsensusProposalToOrdered: max: 0.572, avg: 0.516", "ConsensusOrderedToCommit: max: 0.471, avg: 0.443", "ConsensusProposalToCommit: max: 0.990, avg: 0.960"]
Max round gap was 1 [limit 4] at version 1557788. Max no progress secs was 4.986719 [limit 15] at version 1557788.
Test Ok

@larry-aptos larry-aptos merged commit 0f46f19 into main Feb 14, 2024
79 of 82 checks passed
@larry-aptos larry-aptos deleted the change-theproto branch February 14, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants