Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] dag land blocking-style and stable tests #12004

Merged
merged 16 commits into from
Feb 24, 2024
Merged

Conversation

ibalajiarun
Copy link
Contributor

Description

Test Plan

Copy link

trunk-io bot commented Feb 13, 2024

⏱️ 32h 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 6h 41m 🟩🟩🟩🟩🟩 (+18 more)
rust-unit-tests 6h 10m 🟥🟥🟩🟩 (+14 more)
rust-unit-coverage 4h 40m 🟩
forge-e2e-test / forge 3h 38m 🟥🟥🟥🟥🟥 (+7 more)
rust-smoke-coverage 3h 20m 🟩
rust-images / rust-all 2h 55m 🟩🟩🟩🟩🟩 (+9 more)
run-tests-main-branch 1h 15m 🟥🟥🟥🟥🟥 (+13 more)
rust-lints 1h 9m 🟥🟥🟥🟥 (+14 more)
check-dynamic-deps 54m 🟩🟩🟩🟩🟩 (+19 more)
general-lints 42m 🟩🟩🟩🟩 (+14 more)
check 33m 🟥🟥🟥🟥🟩 (+15 more)
semgrep/ci 9m 🟩🟩🟩🟩🟩 (+18 more)
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+15 more)
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+13 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+9 more)
permission-check 1m 🟩🟩🟩🟩🟩 (+18 more)
permission-check 1m 🟩🟩🟩🟩🟩 (+18 more)
permission-check 50s 🟩🟩🟩🟩🟩 (+13 more)
permission-check 48s 🟩🟩🟩🟩🟩 (+13 more)
determine-docker-build-metadata 38s 🟩🟩🟩🟩🟩 (+9 more)
permission-check 37s 🟩🟩🟩🟩 (+11 more)
upload-to-codecov 12s 🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 7m 4m +64%
rust-images / rust-all 17m 12m +41%
windows-build 26m 19m +39%
forge-e2e-test / forge 20m 14m +36%

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun added CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-forge-e2e-perf Run the e2e perf forge only labels Feb 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun force-pushed the balaji/forge-the-dag branch 2 times, most recently from 0605994 to ac90aea Compare February 14, 2024 03:45
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.8%. Comparing base (e52145d) to head (e185ec6).
Report is 14 commits behind head on main.

❗ Current head e185ec6 differs from pull request most recent head 4e21c07. Consider uploading reports for the commit 4e21c07 to get more accurate results

Files Patch % Lines
consensus/src/dag/dag_driver.rs 0.0% 3 Missing ⚠️
consensus/src/dag/dag_handler.rs 0.0% 2 Missing ⚠️
consensus/src/network.rs 66.6% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #12004     +/-   ##
=========================================
- Coverage    70.3%    69.8%   -0.6%     
=========================================
  Files        2237     2200     -37     
  Lines      421446   417634   -3812     
=========================================
- Hits       296386   291598   -4788     
- Misses     125060   126036    +976     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun changed the title [forge] dag land blocking-style test [forge] dag land blocking-style and stable tests Feb 23, 2024
@ibalajiarun ibalajiarun enabled auto-merge (squash) February 23, 2024 23:52

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 4e21c07fac805af0baab00b14defcafb5d2a97ed

Compatibility test results for aptos-node-v1.9.5 ==> 4e21c07fac805af0baab00b14defcafb5d2a97ed (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 4186 txn/s, latency: 6950 ms, (p50: 5100 ms, p90: 14100 ms, p99: 24100 ms), latency samples: 180000
2. Upgrading first Validator to new version: 4e21c07fac805af0baab00b14defcafb5d2a97ed
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1994 txn/s, latency: 14695 ms, (p50: 17200 ms, p90: 21000 ms, p99: 22000 ms), latency samples: 93740
3. Upgrading rest of first batch to new version: 4e21c07fac805af0baab00b14defcafb5d2a97ed
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 100 txn/s, submitted: 318 txn/s, expired: 218 txn/s, latency: 31238 ms, (p50: 28000 ms, p90: 92900 ms, p99: 92900 ms), latency samples: 14935
4. upgrading second batch to new version: 4e21c07fac805af0baab00b14defcafb5d2a97ed
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2324 txn/s, latency: 12943 ms, (p50: 14800 ms, p90: 16300 ms, p99: 17100 ms), latency samples: 104620
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 4e21c07fac805af0baab00b14defcafb5d2a97ed passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4e21c07fac805af0baab00b14defcafb5d2a97ed

two traffics test: inner traffic : committed: 7267 txn/s, latency: 5400 ms, (p50: 5100 ms, p90: 6600 ms, p99: 14100 ms), latency samples: 3139380
two traffics test : committed: 100 txn/s, latency: 2090 ms, (p50: 1900 ms, p90: 2200 ms, p99: 10400 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.278, avg: 0.208", "QsPosToProposal: max: 0.323, avg: 0.231", "ConsensusProposalToOrdered: max: 0.555, avg: 0.532", "ConsensusOrderedToCommit: max: 0.353, avg: 0.331", "ConsensusProposalToCommit: max: 0.883, avg: 0.863"]
Max round gap was 1 [limit 4] at version 1509168. Max no progress secs was 4.379069 [limit 15] at version 1509168.
Test Ok

@ibalajiarun ibalajiarun merged commit af0d876 into main Feb 24, 2024
67 of 80 checks passed
@ibalajiarun ibalajiarun deleted the balaji/forge-the-dag branch February 24, 2024 00:24
ibalajiarun added a commit that referenced this pull request Feb 29, 2024
* [forge] dag land blocking-style test
* [dag][racefix] dont enter round with strong links
* [dag][forge] changing working quorum test
* [dag][forge] onchain config enable test
* [dag] trace ordered block
ibalajiarun added a commit that referenced this pull request Feb 29, 2024
* [forge] dag land blocking-style test
* [dag][racefix] dont enter round with strong links
* [dag][forge] changing working quorum test
* [dag][forge] onchain config enable test
* [dag] trace ordered block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants