[aip-43] Separate Concurrent Fungible Assets feature flag, for later release

[igor-aptos]

Description

Separating token v2 and fungible asset concurrent feature enabling:

• to start with token v2 only
• and to include the rest of the fungible asset changes (Concurrent FungibleAsset balance #11183) together

Test Plan

[trunk-io]

⏱️ 5h 43m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	1h 6m	🟩 🟩
rust-unit-tests	59m	🟩 ⬜ 🟩
windows-build	43m	🟩 🟩 🟩
rust-move-tests	34m	🟩 🟩
rust-smoke-tests	28m	🟩
execution-performance / single-node-performance	19m	🟩
rust-lints	15m	🟩 ⬜ 🟩
forge-compat-test / forge	14m	🟩
forge-e2e-test / forge	13m	🟩
rust-images / rust-all	12m	🟩
check	9m	🟩 ⬜ 🟩
run-tests-main-branch	9m	🟩 ⬜ 🟩
cli-e2e-tests / run-cli-tests	7m	🟩
check-dynamic-deps	6m	🟩 🟩 🟩
general-lints	5m	🟩 ⬜ 🟩
semgrep/ci	1m	🟩 🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	55s	🟩
file_change_determinator	27s	🟩 🟩 🟩
file_change_determinator	27s	🟩 🟩 🟩
file_change_determinator	12s	🟩
execution-performance / file_change_determinator	11s	🟩
permission-check	9s	🟩 🟩 🟩
permission-check	8s	🟩 🟩 🟩
permission-check	7s	🟩 🟩 🟩
permission-check	7s	🟩 🟩 🟩
permission-check	3s	🟩
determine-docker-build-metadata	3s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
windows-build	14m	18m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[igor-aptos]

Current dependencies on/for this PR:

• main
  • PR [aip-43] Separate Concurrent Fungible Assets feature flag, for later release #11871 👈

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (793563f) 70.1% compared to head (50babba) 71.2%.
Report is 10 commits behind head on main.

❗ Current head 50babba differs from pull request most recent head 9fa8717. Consider uploading reports for the commit 9fa8717 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #11871       +/-   ##
===========================================
+ Coverage    70.1%    71.2%     +1.0%     
===========================================
  Files        2182      794     -1388     
  Lines      414855   182772   -232083     
===========================================
- Hits       291207   130289   -160918     
+ Misses     123648    52483    -71165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vusirikala]

Is it okay to reuse the feature number 37 after deprecating CONCURRENT_ASSETS flag?

[igor-aptos]

yes, it's safe to rename constants.

it is still the same flag (it was never enabled before), we just restrict it to gate less things (and so the rename)

[lightmark]

clean

[github-actions]

✅ Forge suite realistic_env_max_load success on 9fa871747e555de16b358392846b1873e94e5206

two traffics test: inner traffic : committed: 6977 txn/s, latency: 5477 ms, (p50: 5000 ms, p90: 7400 ms, p99: 12600 ms), latency samples: 3021380
two traffics test : committed: 100 txn/s, latency: 2173 ms, (p50: 2100 ms, p90: 2500 ms, p99: 3600 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.223, avg: 0.201", "QsPosToProposal: max: 0.148, avg: 0.139", "ConsensusProposalToOrdered: max: 0.593, avg: 0.552", "ConsensusOrderedToCommit: max: 0.471, avg: 0.448", "ConsensusProposalToCommit: max: 1.028, avg: 1.000"]
Max round gap was 1 [limit 4] at version 1424137. Max no progress secs was 6.719851 [limit 15] at version 1424137.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 9fa871747e555de16b358392846b1873e94e5206

Compatibility test results for aptos-node-v1.8.3 ==> 9fa871747e555de16b358392846b1873e94e5206 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4822 txn/s, latency: 6482 ms, (p50: 6000 ms, p90: 10200 ms, p99: 17500 ms), latency samples: 183260
2. Upgrading first Validator to new version: 9fa871747e555de16b358392846b1873e94e5206
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1758 txn/s, latency: 16696 ms, (p50: 19000 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 91440
3. Upgrading rest of first batch to new version: 9fa871747e555de16b358392846b1873e94e5206
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1789 txn/s, latency: 15812 ms, (p50: 19300 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 93040
4. upgrading second batch to new version: 9fa871747e555de16b358392846b1873e94e5206
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2939 txn/s, latency: 9939 ms, (p50: 9900 ms, p90: 18400 ms, p99: 20300 ms), latency samples: 126400
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 9fa871747e555de16b358392846b1873e94e5206 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking