Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add TransactionInfoDb and TransactionAccumulatorDb as submodules of LedgerDb. #11695

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

grao1991
Copy link
Contributor

Description

Test Plan

Copy link

trunk-io bot commented Jan 18, 2024

⏱️ 11h 52m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 3h 11m 🟩🟥🟩🟩🟩 (+5 more)
rust-unit-tests 2h 34m 🟩🟩🟩 (+5 more)
rust-lints 1h 🟥🟥🟩🟩 (+5 more)
forge-e2e-test / forge 46m 🟥🟥🟩
forge-framework-upgrade-test / forge 44m 🟥
run-tests-main-branch 43m 🟩🟩🟩🟩🟩 (+5 more)
check 38m 🟩🟩🟩🟥 (+5 more)
rust-smoke-tests 27m 🟩
general-lints 24m 🟩🟩🟩🟩 (+5 more)
execution-performance / single-node-performance 21m 🟩
check-dynamic-deps 20m 🟩🟩🟩🟩🟩 (+5 more)
forge-compat-test / forge 15m 🟩
rust-images / rust-all 10m 🟩
cli-e2e-tests / run-cli-tests 9m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
node-api-compatibility-tests / node-api-compatibility-tests 50s 🟩
permission-check 28s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 28s 🟩🟩🟩🟩🟩 (+4 more)
permission-check 27s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 24s 🟩🟩🟩🟩🟩 (+4 more)
execution-performance / file_change_determinator 10s 🟩
file_change_determinator 9s 🟩
execution-performance / sequential-execution-performance 7s 🟩
execution-performance / parallel-execution-performance 7s 🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 12m 8m +40%
windows-build 25m 20m +25%

settingsfeedbackdocs ⋅ learn more about trunk.io

@grao1991 grao1991 requested review from areshand and removed request for lightmark and msmouse January 18, 2024 23:13
@grao1991 grao1991 force-pushed the grao_transaction_info branch 3 times, most recently from 556b653 to dcb3606 Compare January 19, 2024 19:44
@grao1991 grao1991 requested a review from zekun000 January 19, 2024 19:44
@grao1991 grao1991 force-pushed the grao_transaction_info branch 4 times, most recently from 3b523ff to a80984d Compare January 21, 2024 07:10
@grao1991 grao1991 force-pushed the grao_transaction_info branch from a80984d to 151fafd Compare January 22, 2024 05:00
@grao1991 grao1991 enabled auto-merge (squash) January 22, 2024 19:42

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 151fafd8fd130507f5c95baf2150ad2029d44360

Compatibility test results for aptos-node-v1.8.3 ==> 151fafd8fd130507f5c95baf2150ad2029d44360 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4820 txn/s, latency: 6707 ms, (p50: 6400 ms, p90: 10500 ms, p99: 13500 ms), latency samples: 188000
2. Upgrading first Validator to new version: 151fafd8fd130507f5c95baf2150ad2029d44360
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1339 txn/s, latency: 21940 ms, (p50: 22300 ms, p90: 32800 ms, p99: 34100 ms), latency samples: 65640
3. Upgrading rest of first batch to new version: 151fafd8fd130507f5c95baf2150ad2029d44360
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1786 txn/s, latency: 16257 ms, (p50: 19000 ms, p90: 22100 ms, p99: 22600 ms), latency samples: 92920
4. upgrading second batch to new version: 151fafd8fd130507f5c95baf2150ad2029d44360
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3514 txn/s, latency: 9164 ms, (p50: 9900 ms, p90: 13900 ms, p99: 14400 ms), latency samples: 137080
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 151fafd8fd130507f5c95baf2150ad2029d44360 passed
Test Ok

This comment has been minimized.

Copy link
Contributor

❌ Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> 151fafd8fd130507f5c95baf2150ad2029d44360

Compatibility test results for aptos-node-v1.8.3 ==> 151fafd8fd130507f5c95baf2150ad2029d44360 (PR)
Upgrade the nodes to version: 151fafd8fd130507f5c95baf2150ad2029d44360
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11695.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>
Trailing Log Lines:
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at testsuite/forge/src/backend/k8s/swarm.rs:696:18:
called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-11695" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-11695\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-11695" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 151fafd8fd130507f5c95baf2150ad2029d44360

two traffics test: inner traffic : committed: 7268 txn/s, latency: 5278 ms, (p50: 4800 ms, p90: 6700 ms, p99: 15200 ms), latency samples: 3140040
two traffics test : committed: 100 txn/s, latency: 2243 ms, (p50: 2100 ms, p90: 2500 ms, p99: 8900 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.285, avg: 0.210", "QsPosToProposal: max: 0.155, avg: 0.138", "ConsensusProposalToOrdered: max: 0.577, avg: 0.532", "ConsensusOrderedToCommit: max: 0.490, avg: 0.467", "ConsensusProposalToCommit: max: 1.027, avg: 0.999"]
Max round gap was 1 [limit 4] at version 1313837. Max no progress secs was 9.516943 [limit 10] at version 1313837.
Test Ok

@grao1991 grao1991 merged commit 6d29c17 into main Jan 22, 2024
78 of 82 checks passed
@grao1991 grao1991 deleted the grao_transaction_info branch January 22, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants