cleanup

.dockerignore

@@ -22,9 +22,6 @@
 !aptos-move/aptos-release-builder/data/release.yaml
 !aptos-move/aptos-release-builder/data/proposals/*
 !aptos-move/framework/
-!aptos-move/framework/aptos-framework/
-!aptos-move/framework/aptos-stdlib/
-!aptos-move/framework/move-stdlib/
 !aptos-move/move-examples/hello_blockchain/
 !crates/aptos/src/move_tool/*.bpl
 !crates/aptos-faucet/doc/

crates/aptos-api-tester/src/consts.rs

@@ -4,7 +4,7 @@ use once_cell::sync::Lazy;
 use std::{env, time::Duration};
 use url::Url;
 
-// Faucet constants
+// Node and faucet constants
 
 pub static DEVNET_NODE_URL: Lazy<Url> =
     Lazy::new(|| Url::parse("https://fullnode.devnet.aptoslabs.com").unwrap());

crates/aptos-api-tester/src/persistent_check.rs

@@ -1,5 +1,17 @@
 // Copyright © Aptos Foundation
 
+// Persistent checking is a mechanism to increase tolerancy to eventual consistency issues. In our
+// earlier tests we have observed that parallel runs of the flows returned higher failure rates
+// than serial runs, and these extra failures displayed the following pattern: 1) the flow submits
+// a transaction to the API (such as account creation), 2) the flow reads the state from the API,
+// and gets a result that does not include the transaction. We attribute this to the second call
+// ending up on a different node which is not yet up to sync. Therefore, for state checks, we
+// repeat the whole check for a period of time until it is successful, and throw a failure only if
+// it fails to succeed. Note that every time a check fails we will still get a failure log.
+
+// TODO: The need for having a different persistent check wrapper for each function signature is
+// due to a lack of overloading in Rust. Consider using macros to reduce code duplication.
+
 use crate::{
     consts::{PERSISTENCY_TIMEOUT, SLEEP_PER_CYCLE},
     strings::ERROR_COULD_NOT_CHECK,

crates/aptos-rest-client/src/lib.rs

@@ -566,8 +566,8 @@ impl Client {
         F: Fn(HashValue) -> Fut,
         Fut: Future<Output = AptosResult<WaitForTransactionResult<T>>>,
     {
-        // note: make this configurable
-        const DEFAULT_DELAY: Duration = Duration::from_millis(100);
+        // TODO: make this configurable
+        const DEFAULT_DELAY: Duration = Duration::from_millis(500);
         let mut reached_mempool = false;
         let start = std::time::Instant::now();
         loop {