Switch to Docker's GitHub Actions #243

almathew · 2021-12-28T23:13:23Z

No description provided.

almathew · 2021-12-29T20:43:45Z

@UserNotFound also adding you as a reviewer, since I think you or Frank have enough context to review

fancyremarker

Changes look sane, and a nice improvement toward using the most appropriate library actions and more fully automating.

fancyremarker · 2021-12-31T04:24:16Z

.github/workflows/release.yml

+        with:
+          context: .
+          push: true
+          tags: ${{ steps.docker-meta.outputs.tags }}


This looks like it will change the naming convention for Docker repo tags, but I don't see a problem with that.

fancyremarker · 2021-12-31T04:25:12Z

.github/workflows/release.yml

+
+      - name: Deploy code to production
+        uses: aptible/aptible-deploy-action@v1
+        if: startsWith(github.ref, 'refs/tags/')


This looks right. I don't know if it's the standard best practice, but a few other examples suggest yes.

skylar-anderson · 2022-01-04T19:27:30Z

@almathew Is this good to merge so we can unblock deploys?

almathew requested a review from fancyremarker December 28, 2021 23:13

almathew force-pushed the new-workflows branch from c1c1c31 to de4c347 Compare December 28, 2021 23:27

Switch to Docker's Actions

778db26

almathew force-pushed the new-workflows branch from de4c347 to 778db26 Compare December 28, 2021 23:27

almathew requested a review from UserNotFound December 29, 2021 20:43

fancyremarker approved these changes Dec 31, 2021

View reviewed changes

almathew merged commit 35d09b0 into main Jan 4, 2022

Provide feedback