Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zombie process & upgrade bat & go #164

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

qianlongzt
Copy link
Contributor

@qianlongzt qianlongzt commented Sep 2, 2024

fix #88

@UserNotFound UserNotFound removed the request for review from krallin September 3, 2024 16:06
@UserNotFound UserNotFound self-assigned this Sep 3, 2024
Copy link
Member

@UserNotFound UserNotFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission, can you update the Go version to 1.23.0 in the Github actions for test and release, as well?
https://github.com/aptible/supercronic/blob/master/.github/workflows/release.yml#L15
https://github.com/aptible/supercronic/blob/master/.github/workflows/test.yml#L15

@qianlongzt
Copy link
Contributor Author

updated

@UserNotFound UserNotFound self-requested a review September 3, 2024 18:12
Copy link
Member

@UserNotFound UserNotFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in the work to add tests, I'll merge and create a new release today.

@UserNotFound UserNotFound merged commit 32e229c into aptible:master Sep 3, 2024
1 check passed
@UserNotFound UserNotFound mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule job isn't started because of defunct zombie process
3 participants