Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in the HostScoring implementation:
The 3 variables required for the next hit slot
were not reset between events. Although they were ever increased via
unsigned int next = hostScoring_dev->fNextFreeHit_dev->fetch_add(1);
(and thefBufferStart
was set to be thefNextHitFree
), it worked due to the circular nature of the bufferreturn next % hostScoring_dev->fBufferCapacity;
. However, as soon as the maximum int was exceeded, the simulation would simply stall and not do anything else anymore. This PR fixes that by resetting the three variables between events using a new functionResetBufferStatsGPU
.Note that there are a huge amount of changes due to the missing clang formatting in the file. The only other change was to reduce some input parameters for e.g.,
CopyHitsToHost
and just use the hostscoring itself to get the stats.