Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove duplicate MinSizeRel option #291

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

andresailer
Copy link
Contributor

I want to see if the Alma9 CI is working

@phsft-bot
Copy link

Can one of the admins verify this patch?

agheata
agheata previously approved these changes May 28, 2024
@agheata
Copy link
Contributor

agheata commented May 28, 2024

It did not trigger a build though. @andresailer do you want this merged now or do you still want to play with it?

@andresailer
Copy link
Contributor Author

I want to see the build run, I don't want this merged before the build ran successfully on alma9.

(I just ran a spellcheck on CMakeLists.txt, but I would have also just done a dummy change)

@agheata
Copy link
Contributor

agheata commented May 28, 2024

I want to see the build run, I don't want this merged before the build ran successfully on alma9.

OK, no problem, let me know if anything you may need

@agheata agheata dismissed their stale review May 28, 2024 12:11

testing

@andresailer
Copy link
Contributor Author

I think someone has to tell the bot to run the pipeline?

@andresailer
Copy link
Contributor Author

@adept-bot bot build

@andresailer
Copy link
Contributor Author

@phsft-bot bot build

@andresailer
Copy link
Contributor Author

sft-bot build

@andresailer
Copy link
Contributor Author

@phsft-bot build

@andresailer
Copy link
Contributor Author

@agheata Can you tell the bot to build?

@agheata
Copy link
Contributor

agheata commented May 28, 2024

I don't see the pipeline in the AdePT-CI. It normally starts automatically, maybe it detected that no dependencies were changed so no build is needed (just shooting in the dark)

@andresailer
Copy link
Contributor Author

I think I am not in some list of developers, so the bot doesn't start the pipeline unless someone verifies somehow

@agheata
Copy link
Contributor

agheata commented May 28, 2024

In such case it should prompt me to start the pipeline, which it doesn't. I managed to restart the pipeline for #289 https://lcgapp-services.cern.ch/spi-jenkins/job/AdePT-CI/661/

@agheata
Copy link
Contributor

agheata commented May 28, 2024

Which runs happily on centos7
Running on lcgapp-centos7-x86-64-gpu-03 in /build/sftnight/workspace/AdePT-CI

@agheata
Copy link
Contributor

agheata commented May 28, 2024

I just pushed to your branch, let's see

@agheata
Copy link
Contributor

agheata commented May 28, 2024

I just pushed to your branch, let's see

OK, so even if I push, it won't start the pipeline

@andresailer
Copy link
Contributor Author

Can you say @phsft-bot build Without the tick marks?

@agheata
Copy link
Contributor

agheata commented May 28, 2024

@phsft-bot build

@agheata
Copy link
Contributor

agheata commented May 28, 2024

@phsft-bot rebuild

@agheata
Copy link
Contributor

agheata commented May 28, 2024

Nothing...
The project is configured to send notifications to the webhook: https://github.com/apt-sim/AdePT/settings/hooks/277932760

@andresailer
Copy link
Contributor Author

Thanks for trying!

@andresailer andresailer reopened this May 29, 2024
@andresailer
Copy link
Contributor Author

@phsft-bot test this please

@andresailer
Copy link
Contributor Author

@phsft-bot retest this please

@agheata
Copy link
Contributor

agheata commented May 29, 2024

@andresailer I see that the build was done, but still on centos7 ?
Running on lcgapp-centos7-x86-64-gpu-02 in /build/sftnight/workspace/AdePT-CI

@andresailer
Copy link
Contributor Author

No, this is alma9, the name of the machine is just the same as before.

@andresailer andresailer reopened this May 29, 2024
@agheata
Copy link
Contributor

agheata commented May 29, 2024

OK, then it should be working.

@andresailer
Copy link
Contributor Author

Then I will also migrate the other GPU machine to alma9?

@agheata
Copy link
Contributor

agheata commented May 29, 2024

Then I will also migrate the other GPU machine to alma9?

Yes, why not

@agheata
Copy link
Contributor

agheata commented May 29, 2024

@andresailer it seems that now all nodes labeled cuda10 have disappeared, so the VecGeom pipeline stalls

@agheata
Copy link
Contributor

agheata commented Jun 4, 2024

@andresailer I guess we can close this since the CI is migrated?

@andresailer
Copy link
Contributor Author

Yes, you can also merge it :)

@agheata agheata merged commit 92851f7 into apt-sim:master Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants