Use VecGeom recommendations for device linking #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in VecGeom README and build scripts, have to be _very_ careful about linking to CUDA component when we ourselves use VecGeom's CUDA functions. Update AdePT to use these by 1. Linking to vecgeomcuda privately, add vecgeomcuda_static to device link step. 2. Use CUDA_RUNTIME_LIBRARY as "Shared" to link to same runtime as used by vecgeomcuda Public link to vecgeom is retained currently due to AdePT_G4_integration still exposing some of VecGeom in its interfaces.
|
Can one of the admins verify this patch? |
|
Closing as superseded by #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in VecGeom README and build scripts, we have to be very careful about linking to its CUDA component when we ourselves use VecGeom's CUDA functions. This is a small update to AdePT to use these recommendations:
vecgeomcudaprivately, addingvecgeomcuda_staticto the device link step.CUDA_RUNTIME_LIBRARYas "Shared" to link to same runtime as used byvecgeomcudaThe public link to
vecgeomis retained currently due toAdePT_G4_integrationstill exposing some of VecGeom in its interfaces, which is fine for now.This change is required to allow use of G4VG for in memory use of Geant4-VecGeom conversions, but I've submitted just the linking change in isolation first to cross-check if this exposes
as-needed(it doesn't locally at least) or performance issues.