Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py_binary rule for console_scripts #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 62 additions & 2 deletions src/piprules/bazel.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,20 @@ def library_dependencies(self):
for req in self.distribution.requires()
)

@property
def console_entry_points(self):
return self.distribution.get_entry_map("console_scripts").keys()

def generate(self):
self._create_base_package_build_file()

for data_directory in self._find_data_directories():
_DataPackageGenerator(self.base_package_path, data_directory).generate()
_DataPackageGenerator(self.base_package_path,
data_directory).generate()

entry_points = self.console_entry_points
if entry_points:
self._generate_bin_build_file()

def _create_base_package_build_file(self):
# Files with spaces in the name must be excluded
Expand All @@ -69,12 +78,63 @@ def _create_base_package_build_file(self):
)
""").lstrip().format(
name=self.library_name,
deps=_create_string_list(dep.label for dep in self.library_dependencies),
deps=_create_string_list(
dep.label for dep in self.library_dependencies),
)

with open(self.base_package_build_file_path, mode="w") as build_file:
build_file.write(contents)

def _generate_bin_build_file(self):
contents = "".join([
textwrap.dedent("""
py_binary(
name = "{rule}",
srcs = ["bin/{entry_point}.py"],
deps = [":{library_name}"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to provide main = "bin/{entry_point}.py" here, because in the case when {rule} has bin- prepended it won't match automatically.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Thank for catching that.

visibility = ["//visibility:public"],
)
""").lstrip().format(
rule="bin-" + ep if ep == self.library_name else ep,
entry_point=ep,
package_name=self.base_package_name,
library_name=self.library_name,
) for ep in self.console_entry_points
])

# Create bin directory
dirname = os.path.join(self.base_package_path, "bin")
os.makedirs(dirname, exist_ok=True)

# Generate scripts
from setuptools.command.install_scripts import install_scripts
from setuptools.dist import Distribution
dist = Distribution({
"name": self.distribution.key,
"version": self.distribution.version,
"entry_points": {
'console_scripts': [
str(val) for _, val in
self.distribution.get_entry_map("console_scripts").items()
]
}
})
dist.script_name = "setup.py"
cmd = install_scripts(dist)
cmd.install_dir = dirname
cmd.ensure_finalized()
cmd.run()

# Add .py suffix. Bazel py_binary rule requires it
for f in os.listdir(dirname):
if not f.endswith(".py"):
fullname = os.path.join(dirname, f)
os.rename(fullname, fullname + ".py")

# Generate build file
with open(self.base_package_build_file_path, mode="a") as build_file:
build_file.write(contents)

def _find_data_directories(self):
return glob.glob(self.data_source_pattern)

Expand Down
Binary file modified tools/compile_pip_requirements.par
Binary file not shown.
Binary file modified tools/create_pip_repository.par
Binary file not shown.