Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add skip to content link #359

Merged
merged 3 commits into from
Dec 18, 2023
Merged

feat:add skip to content link #359

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9462493
add skip to content link
ketanbaitule Nov 18, 2023
1249df1
merge with main
TGlide Dec 18, 2023
6d3a742
styling changes
TGlide Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/lib/layouts/Docs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,20 @@

setContext('isDocs', true);
</script>

<style>
.skip-to-content-link {
z-index: 1000;
padding: 8px;
position: absolute;
top: 0;
-webkit-transform: translateY(-999px);
transform: translateY(-999px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use opacity instead of translations?

}
.skip-to-content-link:focus {
transform: translateY(0%);
}
</style>
<a class="skip-to-content-link" href="#main">Skip to content</a>
<div class="u-position-relative">
<section class="aw-mobile-header is-transparent">
<div class="aw-mobile-header-start">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/DocsArticle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
export let date: string;
</script>

<main class="u-contents">
<main class="u-contents" id="main">
<article class="aw-article u-contents">
<header class="aw-article-header">
<div class="aw-article-header-start u-flex-vertical aw-u-cross-start">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/DocsTutorial.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
$: prevStep = tutorials.find((tutorial) => tutorial.step === currentStep - 1);
</script>

<main class="u-contents">
<main class="u-contents" id="main">
<article class="aw-article u-contents">
<header class="aw-article-header">
<div class="aw-article-header-start u-flex-vertical aw-u-cross-start">
Expand Down
2 changes: 1 addition & 1 deletion src/markdoc/layouts/Policy.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@
</div>
</aside>
<main class="aw-grid-120-1fr-auto-main /aw-is-mobile-closed" id="policy-content">
<div class="aw-content is-count-headers" class:aw-is-mobile-closed={showToc}>
<div class="aw-content is-count-headers" class:aw-is-mobile-closed={showToc} id="main">
<!-- eslint-disable-next-line svelte/valid-compile -->
<h2 aria-hidden="true">Introduction</h2>
<slot />
Expand Down
2 changes: 1 addition & 1 deletion src/routes/assets/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
</ul>
</div>
</aside>
<main class="aw-grid-120-1fr-auto-main /aw-is-mobile-closed">
<main class="aw-grid-120-1fr-auto-main /aw-is-mobile-closed" id="main">
<div class="aw-content">
<section>
<p>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/docs/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
/>
</div>

<main class="aw-main-section u-position-relative">
<main class="aw-main-section u-position-relative" id="main">
<div class="u-position-absolute aw-u-opacity-40-mobile bg-blur">
<img src="/images/bgs/docs-blur-1.svg" alt="" />
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/docs/quick-starts/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
<meta name="twitter:card" content="summary_large_image" />
</svelte:head>

<main class="aw-main-section">
<main class="aw-main-section" id="main">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding it to pages alone won't be enough, we should add them to all relevant layouts

<article class="aw-article">
<header class="aw-article-header">
<div class="aw-article-header-start u-flex-vertical aw-u-cross-start">
Expand Down
2 changes: 1 addition & 1 deletion src/routes/docs/references/[version]/[platform]/[service]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
<meta name="twitter:card" content="summary_large_image" />
</svelte:head>

<main class="u-contents">
<main class="u-contents" id="main">
<article class="aw-article u-contents">
<header class="aw-article-header">
<div class="aw-article-header-start">
Expand Down
2 changes: 1 addition & 1 deletion src/routes/docs/tutorials/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<meta name="twitter:card" content="summary_large_image" />
</svelte:head>

<main class="aw-main-section">
<main class="aw-main-section" id="main">
<article class="aw-article">
<header class="aw-article-header">
<div class="aw-article-header-start u-flex-vertical aw-u-cross-start">
Expand Down