feat: pre release modal #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArmanNik
commented
Dec 1, 2023
•
ArmanNik
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
reviewed
Dec 1, 2023
Comment on lines
+63
to
+64
| export { default as ModalWrapper } from './modalWrapper.svelte'; | ||
| export { default as ModalSideCol } from './modalSideCol.svelte'; |
There was a problem hiding this comment.
Would it be better to not expose these and only use ?
| export let show = false; | ||
| </script> | ||
|
|
||
| <ModalSideCol bind:show title="Get ready for Appwrite Pro" style="max-width: min(53rem,95%)"> |
There was a problem hiding this comment.
Is it possible to still have a single but have it look different if it has a side slot?
| <Button | ||
| fullWidth | ||
| class="u-margin-block-start-24" | ||
| href="https://appwrite.io/pricing" |
There was a problem hiding this comment.
Should this be linking to pro?
| </p> | ||
| </div> | ||
| <Box> | ||
| <b class="body-text-1">Pro - $15 per member per billing period</b> |
There was a problem hiding this comment.
Suggested change
| <b class="body-text-1">Pro - $15 per member per billing period</b> | |
| <b class="body-text-1">Pro - $15 per member per billing period</b> |
Do we want to simplify it and just say "per month" like it is on our website
christyjacob4
approved these changes
Dec 4, 2023
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.