Console Feat: make budget cap nullable #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohanidamodar
requested review from
ArmanNik,
TorstenDittmann and
ItzNotABug
ItzNotABug
requested changes
Feb 18, 2025
ItzNotABug
approved these changes
Feb 18, 2025
| @@ -168,7 +168,7 @@ | |||
|
|
|||
| trackEvent(Submit.OrganizationCreate, { | |||
| plan: tierToPlan(billingPlan)?.name, | |||
| budget_cap_enabled: !!billingBudget, | |||
| budget_cap_enabled: billingBudget != null, | |||
There was a problem hiding this comment.
lets use strict inequality
|
|
||
| let capActive = false; | ||
| let budget: number; | ||
|
|
||
| onMount(() => { | ||
| budget = $organization?.billingBudget; | ||
| capActive = !!$organization?.billingBudget; | ||
| capActive = $organization?.billingBudget != null; |
There was a problem hiding this comment.
!= null will be true for 0 as well
christyjacob4
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
YES