Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notifications sa-251 teams and sa-228 enrichmenbt #9

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

wozzer72
Copy link
Contributor

@wozzer72 wozzer72 commented Sep 10, 2024

Utilising V1.0.1 of notifications to benefit from enriched Slack messaging.

Includes removing defunct slack channel and username and passing through of accounts id to name mapping.

NOTE - teams-budgets is not going to work: slack_notification does not exist on "budgets" variable. This is existing behaviour.

Have also taken the opportunity to replace the direct dependency on terraform-aws-modules/notify-slack in teams-budget module with the appvia notifications module.

Copy link

github-actions bot commented Sep 10, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/team-budgets
Pusher: @wozzer72, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-budgets/actions/runs/10808316963

Copy link

github-actions bot commented Sep 10, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/budgets
Pusher: @wozzer72, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-budgets/actions/runs/10808316963

@wozzer72 wozzer72 requested a review from gambol99 September 10, 2024 15:08
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozzer72 wozzer72 merged commit 66a8f02 into main Sep 11, 2024
22 checks passed
@wozzer72 wozzer72 deleted the feat/sa-251-teams branch September 11, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants