Add Dockerfile, built image on push #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also works on Windows Docker Desktop For building on arm it seems that node has some issues there: https://github.com/StefanLobbenmeier/lavamusic/runs/4794300507?check_suite_focus=true Looks like I am facing this issue: aredridel/node-bin-gen#59 |
StefanLobbenmeier
force-pushed
the
dockerfile-for-brblacky
branch
from
15a687c to
0de5f60
Compare
|
I was able to fix the arm build 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im pretty new to the Github Actions, so I am hoping this will work anyway.
I also linked my own repository https://github.com/StefanLobbenmeier/lavamusic-docker-compose in the readme, I hope that is okay for you. Otherwise feel free to fork it and change the link to your fork.
I tested the container on Manjaro, will do another test on Windows using Docker Desktop. The container did not work on my raspberry pi 4 (armv7), so I will do another PR if I figure out how to make it work on that.