-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add apparmor profiles for ubuntu 24.04 or higher distros #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrDaveD
requested changes
Jun 10, 2024
JasonYangShadow
force-pushed
the
issue/2027
branch
4 times, most recently
from
June 18, 2024 08:11
5b40970
to
341a4a8
Compare
@DrDaveD thanks for the comments, I've updated the PR |
DrDaveD
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things remain and a rebase due to merge conflict.
JasonYangShadow
force-pushed
the
issue/2027
branch
2 times, most recently
from
June 19, 2024 01:05
ed9bcc3
to
b729ce9
Compare
Now this one has a merge conflict, sorry |
DrDaveD
requested changes
Jun 19, 2024
Signed-off-by: jason yang <[email protected]>
JasonYangShadow
force-pushed
the
issue/2027
branch
from
June 19, 2024 01:44
b729ce9
to
266c0eb
Compare
DrDaveD
approved these changes
Jun 19, 2024
Please also cherry-pick to release-1.3 |
nsoranzo
added a commit
to nsoranzo/setup-apptainer
that referenced
this pull request
Dec 17, 2024
in particular to include apptainer/apptainer#2262
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Dec 17, 2024
(which started failing since ubuntu-latest was moved to 24.04) by upgrading apptainer to >=1.3.3 to include apptainer/apptainer#2262 . Fix: ``` > assert "samtools:1.0--1" in results["passed"], results E AssertionError: E {'failed': [{'commands': ['python -c "import pyBigWig; assert(pyBigWig.numpy ' E '== 1); assert(pyBigWig.remote == 1)"'], E 'container': 'pybigwig:0.3.22--py36h54a71a5_0', E 'errors': [{'command': 'python -c "import pyBigWig; ' E 'assert(pyBigWig.numpy == 1); ' E 'assert(pyBigWig.remote == 1)"', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}, E {'import': 'pyBigWig', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}], E 'import_lang': 'python -c', E 'imports': ['pyBigWig']}, E {'commands': ['samtools view --help 2>&1 | grep Notes > /dev/null'], E 'container': 'samtools:1.0--1', E 'errors': [{'command': 'samtools view --help 2>&1 | grep Notes > ' E '/dev/null', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}], E 'import_lang': 'python -c'}], E 'notest': ['yasm:1.3.0--0'], E 'passed': []} E assert 'samtools:1.0--1' in [] ``` Also: - Improve assertion messages to facilitate debugging
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Dec 18, 2024
(which started failing since ubuntu-latest was moved to 24.04) by upgrading apptainer to >=1.3.3 to include apptainer/apptainer#2262 . Fix: ``` > assert "samtools:1.0--1" in results["passed"], results E AssertionError: E {'failed': [{'commands': ['python -c "import pyBigWig; assert(pyBigWig.numpy ' E '== 1); assert(pyBigWig.remote == 1)"'], E 'container': 'pybigwig:0.3.22--py36h54a71a5_0', E 'errors': [{'command': 'python -c "import pyBigWig; ' E 'assert(pyBigWig.numpy == 1); ' E 'assert(pyBigWig.remote == 1)"', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}, E {'import': 'pyBigWig', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}], E 'import_lang': 'python -c', E 'imports': ['pyBigWig']}, E {'commands': ['samtools view --help 2>&1 | grep Notes > /dev/null'], E 'container': 'samtools:1.0--1', E 'errors': [{'command': 'samtools view --help 2>&1 | grep Notes > ' E '/dev/null', E 'output': '\x1b[91mERROR : Could not write info to ' E 'setgroups: Permission denied\n' E '\x1b[0m\x1b[91mERROR : Error while ' E 'waiting event for user namespace mappings: ' E 'no event received\n' E '\x1b[0m'}], E 'import_lang': 'python -c'}], E 'notest': ['yasm:1.3.0--0'], E 'passed': []} E assert 'samtools:1.0--1' in [] ``` Also: - Improve assertion messages to facilitate debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
add apparmor profiles for ubuntu 24.04 or higher distros
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).