Fixed the problem discussed in issues 513 #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f an view (fix problems with the cells)
| + (void)load { | ||
| static dispatch_once_t onceToken; | ||
| dispatch_once(&onceToken, ^{ | ||
| Class class = [self class]; |
There was a problem hiding this comment.
Method swizzling in Typhoon is implemented by TyphoonMethodSwizzler
I think would be better use this util class instead your duplicate ;)
|
@CognitiveDisson thanks for fixes - looks great for me! |
|
@CognitiveDisson Looks good for me too |
|
Sorry for delay. Finally I did complex review of this PullRequest. This looks good - thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution with a subclass does not work ( in the ios 10 no more ivar firstItem, secondItem).
In the pull request, I implemented another more complicated solution. It works correctly on all operating system versions. I also added integration tests on the transfer of outlets. I hope you are satisfied with this solution, unfortunately more elegant and working solution could not be found. Even with the use swizzle (these solutions also tried).