Added conformsToProtocol feature for typhoon matcher #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,11 +24,13 @@ @interface TyphoonOptionMatch : NSObject | |||
| @property (nonatomic, strong) id value; | |||
| @property (nonatomic) Class memberClass; | |||
| @property (nonatomic) Class kindClass; | |||
| @property (nonatomic) Protocol *proto; | |||
There was a problem hiding this comment.
Let's use the full name here (and in every other place too) - protocol (or, if it's reserved, something like conformProtocol.
|
@Emailrus Thanks for contributing! I've just reviewed your PR - it looks awesome! 🎉 Just a few style objections from me - and we can merge it. |
|
Thanks @Emailrus for contribution and @igrekde for review. I've reviews and totally agreed with @igrekde :-) Let's merge right after minor spelling fixes |
|
Done and thanks for the lib |
|
Thanks! |
etolstoy
added a commit
that referenced
this pull request
Dec 1, 2015
Added conformsToProtocol feature for typhoon matcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #454