Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global namespace is not applied properly for TyphoonConfigPostProcessors #474

Closed
etolstoy opened this issue Jan 23, 2016 · 0 comments
Closed

Global namespace is not applied properly for TyphoonConfigPostProcessors #474

etolstoy opened this issue Jan 23, 2016 · 0 comments
Assignees
@etolstoy
Labels
bug ready-for-review

Comments

@etolstoy
Copy link
Contributor

TyphoonAssemblyDefinitionBuilder, line 90 - we should check if the namespace is already registered. Current implementation proceeds a bug for TyphoonConfigPostProcessors registered using + (instancetype)configDefinitionWithName:(NSString *)fileName - they should belong to a global namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etolstoy etolstoy

Labels
bug ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etolstoy