ci: Adding snowflake env #39031
ci: Adding snowflake env #39031
Conversation
WalkthroughThis update enhances multiple GitHub Actions workflows by adding Snowflake credentials as environment variables for Cypress test runs. Additionally, it introduces new input parameters and refined control flows in some workflows, including a fallback mechanism for test specifications and conditional logic for snapshot updates and Docker artifact selection. All changes extend the existing configurations without removing any current functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant W as GitHub Actions (ci-test-limited-with-count)
participant F as File System
participant C as Cypress Test Runner
U->>W: Trigger workflow with inputs (run_count, update_snapshot, specs_to_run)
alt specs_to_run provided
W->>W: Use provided specs
else specs_to_run not provided
W->>F: Read fallback file (limited-tests.txt)
F-->>W: Return specs with debug logs
end
W->>W: Set environment variables (Snowflake creds and CYPRESS_updateSnapshots based on update_snapshot)
W->>C: Execute Cypress tests with updated configuration
sequenceDiagram
participant W as GitHub Actions (ci-test-limited)
participant A as Artifact Manager
participant C as Cypress Test Runner
W->>W: Check for previous-workflow-run-id input
alt previous-workflow-run-id provided
W->>A: Download Docker image artifact
else Not provided
W->>A: Use default Docker image artifact
end
W->>W: Set Snowflake credentials as environment variables
W->>C: Run Cypress tests with artifact and new configuration
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-test-limited-with-count.yml (1)
144-205: Robust Specs Fallback Logic:
The “Get specs to run” step implements a comprehensive mechanism to determine the spec files. It first checks the provided inputs (via bothinputs.specs_to_runandgithub.event.inputs.specs_to_run), and if missing or set to 'no_data', it falls back to reading from thelimited-tests.txtfile. The debug logging within this block is helpful for troubleshooting. Consider removing or reducing the verbosity of debug logs in production if desired.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 150-150: trailing spaces
(trailing-spaces)
[error] 177-177: trailing spaces
(trailing-spaces)
[error] 205-205: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci-test-custom-script.yml(1 hunks).github/workflows/ci-test-hosted.yml(1 hunks).github/workflows/ci-test-limited-with-count.yml(1 hunks).github/workflows/ci-test-limited.yml(1 hunks)
🔇 Additional comments (5)
.github/workflows/ci-test-hosted.yml (1)
248-250: Snowflake Credentials Added:
New environment variables (SNOWFLAKE_ACCOUNT_NAME,SNOWFLAKE_USERNAME, andSNOWFLAKE_PASSWORD) have been added to the Cypress test step’s environment. Please ensure the corresponding secrets are defined in the repository settings so that the workflow can access them securely..github/workflows/ci-test-limited.yml (1)
342-344: Snowflake Credentials Integrated:
The Snowflake environment variables are now included in the “Run the cypress test” step. Their naming and placement are consistent with other workflows, which helps maintain uniformity across CI configurations..github/workflows/ci-test-custom-script.yml (1)
371-373: Snowflake Environment Variables Inclusion:
The new Snowflake credentials (SNOWFLAKE_ACCOUNT_NAME,SNOWFLAKE_USERNAME, andSNOWFLAKE_PASSWORD) have been added to the workflow’s environment. This change aligns with the updates in the other workflows and looks correctly implemented..github/workflows/ci-test-limited-with-count.yml (2)
5-59: New Input Parameters for Enhanced Configurability:
The workflow now accepts additional inputs (run_count,update_snapshot, andspecs_to_run) under both theworkflow_dispatchandworkflow_calltriggers. These inputs are clearly described with sensible default values, providing extra flexibility for test repetition and snapshot control.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 23-23: wrong indentation: expected 8 but found 10
(indentation)
[warning] 50-50: wrong indentation: expected 8 but found 10
(indentation)
426-428: Consistent Snowflake Credentials Addition:
Snowflake-related environment variables (SNOWFLAKE_ACCOUNT_NAME,SNOWFLAKE_USERNAME, andSNOWFLAKE_PASSWORD) have been added to the test execution environment in this workflow as well. This ensures a uniform configuration for Snowflake integration across all workflows.
Description
Adding env.
Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39030
Automation
/ok-to-test tags="@tag.SignIn"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13155682886
Commit: d3ca22a
Cypress dashboard.
Tags:
@tag.SignInSpec:
Wed, 05 Feb 2025 11:05:02 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit