Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't tag latest when not latest version #38296

Merged
merged 4 commits into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions .github/workflows/github-release.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Appsmith Github Release Workflow
name: Github Release

# This workflow builds Docker images for server and client, and then pushes them to Docker Hub.
# The docker-tag with which this push happens is `latest` and the release tag (e.g., v1.2.3 etc.).
Expand All @@ -17,24 +17,27 @@ jobs:
runs-on: ubuntu-latest

outputs:
tag: ${{ steps.get_version.outputs.tag }}
tag: ${{ steps.main.outputs.tag }}
docker_tags: ${{ steps.main.outputs.docker_tags }}

steps:
- name: Environment details
run: |
echo "PWD: $PWD"
echo "GITHUB_REF: $GITHUB_REF"
echo "GITHUB_SHA: $GITHUB_SHA"
echo "GITHUB_EVENT_NAME: $GITHUB_EVENT_NAME"
- uses: actions/checkout@v4
with:
ref: ${{ github.ref }}
fetch-depth: "5"
fetch-tags: "true"

- name: Get the version
id: get_version
run: |
if ! [[ ${GITHUB_REF-} =~ ^refs/tags/v[[:digit:]]\.[[:digit:]]+(\.[[:digit:]]+)?$ ]]; then
echo "Invalid tag: '${GITHUB_REF-}'. Has to be like `v1.22`, `v1.22.33` only."
exit 1
fi
echo "tag=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT
- name: Prelude checks and preparations
uses: actions/github-script@v7
id: main
with:
script: |
require(
"${{ github.workspace }}/.github/workflows/scripts/github-release/prelude.js",
)(
{ core, context, github },
"${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-${{ vars.EDITION }}",
)

client-build:
needs:
Expand Down Expand Up @@ -273,5 +276,4 @@ jobs:
APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY }}
BASE=${{ vars.DOCKER_HUB_ORGANIZATION }}/base-${{ vars.EDITION }}:nightly
tags: |
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-${{ vars.EDITION }}:${{needs.prelude.outputs.tag}}
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-${{ vars.EDITION }}:latest
${{ needs.prelude.outputs.docker_tags }}
53 changes: 53 additions & 0 deletions .github/workflows/scripts/github-release/prelude.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
const { exec } = require("child_process");

module.exports = async function ({ core, context }, imageRepo) {
core.summary.addTable([
[{ data: "PWD", header: true }, process.cwd()],
[{ data: "GITHUB_REF", header: true }, context.ref],
[{ data: "GITHUB_SHA", header: true }, context.sha],
[{ data: "GITHUB_EVENT_NAME", header: true }, context.eventName],
]);

if (!context.ref?.match(/^refs\/tags\/v/)) {
core.setFailed(`Invalid tag: '${context.ref}'. Has to be like 'v1.22', 'v1.22.33' only.`);
return;
}

// Current version being tagged, including the 'v' prefix.
const thisVersion = context.ref.replace("refs/tags/", "");
core.setOutput("tag", thisVersion);

// The latest version of Appsmith available, including the 'v' prefix, including the currently tagged version.
const latestVersion = await getLatestTag();

// The docker tags to be pushed to the registry.
const dockerTags = [
`${imageRepo}:${thisVersion}`,
];

if (latestVersion === thisVersion) {
dockerTags.push(`${imageRepo}:latest`);
}

core.summary.addHeading("Docker image tags", 3);
core.summary.addCodeBlock(dockerTags.join("\n"));
core.setOutput("docker_tags", dockerTags.join("\n"));

core.summary.write();
}

function getLatestTag() {
return new Promise((resolve, reject) => {
exec("git tag --list --sort=-version:refname 'v*' | head -1", (error, stdout, stderr) => {
if (error) {
reject(`exec error: ${error}`);
return;
}
if (stderr) {
reject(`stderr: ${stderr}`);
return;
}
resolve(stdout.trim());
});
});
}
Loading