-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable new toolbar for cypress #37148
Merged
Merged
Changes from 18 commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
bb66e9b
feat: Enable new toolbar for cypress
albinAppsmith 80c129a
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 7c12f3c
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith d6d98e4
fix: query rename and run button
albinAppsmith fd0f077
fix: more action trigger test id added
albinAppsmith 83a6965
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 926a951
fix: locators fix
albinAppsmith 870de4b
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 9bb8064
fix: setting tab selector fix
albinAppsmith cff6304
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 5ef38fd
fix: failures
albinAppsmith fe6715f
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 04bd623
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 1d1a836
fix: rename locator fixes
albinAppsmith 665eeb4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith f13e683
fix: js menu locators
albinAppsmith 5f38a74
fix api locators
albinAppsmith 7fd42ec
fix: Removed unused locators
albinAppsmith 3950053
fix: setting popover selectors
albinAppsmith ebf037c
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 173479c
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 7bf8c53
fix: jsobject tests
albinAppsmith 829dd77
fix: api url selectoir fix
albinAppsmith 597f7e4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 8fbc025
fix: locators
albinAppsmith 98da06d
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 3deca4c
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 2433f0f
docs locator fix
albinAppsmith 2cb0438
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 4794d69
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith ba1bf6b
fix settings locators replaced with plugin form function
albinAppsmith 6ea0d15
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith ab55a02
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 73aa79f
fix eslint in cypress
albinAppsmith 99e61d3
commented code reverted
albinAppsmith 9bdaf3f
fix: removed trailing comma which caused cypress failure
albinAppsmith f290fce
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 021e2d6
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 80ba37b
fix: Added response pane class for cypress
albinAppsmith 0c700a1
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith ced13ac
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 268dc3a
fix: cypress datasource failures
albinAppsmith ec51150
fix: Logs2_spec.js
albinAppsmith e1f142b
fix: JSEditorIndent_spec
albinAppsmith 761445d
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith d55d23b
fix: Logs2_spec
albinAppsmith 129a988
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith bb89fb7
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith e2ce9ce
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 8cf58d1
fix: folder name change
albinAppsmith 5df1a96
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith bbf5e77
fix: import fix
albinAppsmith 7d0fd07
feat: uupdated JSEditorComment_spec.js visual tests
albinAppsmith c85eff5
feat: Updated visual test for JSEditorIndent_spec.js
albinAppsmith 2c0be98
feat: updated JSEditorSaveAndAutoIndent_spec.js visual test
albinAppsmith 7380053
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith f3ef4d4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith a5b2f86
fix: cypress failures on mongo template menu
albinAppsmith ac9d4b9
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith a63fb46
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith ca09d6e
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 6a09d77
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 5ff81bb
feat: Added data test id for plugin editor forms
albinAppsmith a492f6a
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith f0c7176
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 9d44e45
feat: added test ids and package check
albinAppsmith bae5e7d
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith d385796
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 19aa481
fix: Added empty message in js settings
albinAppsmith db715e7
fix: Added callback for rename in cypress datasource
albinAppsmith b6a87f6
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 2e35b2a
fix: try removing useInitFormEvaluation
albinAppsmith aaf8a11
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith e084346
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 87ba494
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith bb3e617
fix: removed editor config check
albinAppsmith f2af870
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("PostgreSQL"); | ||
dsName = "Postgres" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
_.dataSources.EditDatasource(); | ||
Comment on lines
25
to
26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove explicit sleep calls. Replace -_.dataSources.SaveDatasource();
-_.agHelper.Sleep();
+_.dataSources.SaveDatasource();
+_.agHelper.WaitUntilToastDisappear();
|
||
|
@@ -39,7 +39,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("Authenticated API"); | ||
dsName = "AuthDS" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.FillAuthAPIUrl(); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
|
@@ -62,7 +62,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("MongoDB"); | ||
dsName = "Mongo" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.FillMongoDSForm(); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
|
@@ -86,7 +86,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("MongoDB"); | ||
dsName = "Mongo" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.FillMongoDSForm(); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
|
@@ -110,7 +110,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("MongoDB"); | ||
dsName = "Mongo" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.FillMongoDSForm(); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
|
@@ -133,7 +133,7 @@ describe( | |
// because I do not need to fill the datasource form and use the same default data | ||
_.dataSources.CreatePlugIn("MongoDB"); | ||
dsName = "Mongo" + uid; | ||
_.agHelper.RenameWithInPane(dsName, false); | ||
_.agHelper.RenameDatasource(dsName); | ||
_.dataSources.FillMongoDSForm(); | ||
_.dataSources.SaveDatasource(); | ||
_.agHelper.Sleep(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using data-cy attributes for dropdown selections
Replace string selectors with data-cy attributes for better maintainability.
Also applies to: 56-57