-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Testing pipeline with build yaml and run_count #35524
Conversation
WalkthroughThe recent updates to the GitHub Actions workflows significantly enhance configurability by introducing a new input parameter, Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Workflow
participant Yarn as Yarn Cache
participant Cypress as Cypress Test Suite
CI->>Yarn: Check cache restoration
alt Cache Restored
Yarn-->>CI: Restore dependencies
else Cache Not Restored
CI->>Cypress: Install dependencies directly
end
CI->>Cypress: Run limited tests
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
/ci-test-limit-count run_count=3 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10286295709. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/ci-test-limited-with-count.yml (1 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/ci-test-limited-with-count.yml
- app/client/cypress/limited-tests.txt
/ci-test-limit-count run_count=3 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10286660273. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-client-server-count.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build-client-server-count.yml (1)
134-134
: Verify the correct integration of therun_count
parameter.The addition of the
run_count
parameter appears to be correct. Ensure that the parameter is correctly referenced in the downstream workflow and does not introduce any syntax errors or logical issues.
/ci-test-limit-count run_count=3 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10287045314. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-client-server-count.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build-client-server-count.yml
/ci-test-limit-count run_count=3 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10287646385. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-client-server-count.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build-client-server-count.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-client-server-count.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build-client-server-count.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build-client-server-count.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build-client-server-count.yml
/ci-test-limit-count run_count=3 |
1 similar comment
/ci-test-limit-count run_count=3 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10472300573. |
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10474182523. |
Description
Testing the yaml with slash command.
Fixes #
34956
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10316110580
Commit: 41a74c7
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Fri, 09 Aug 2024 08:43:58 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
run_count
, improving configurability and responsiveness to events.