Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Testing pipeline with build yaml and run_count #35524

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Aug 7, 2024

Description

Testing the yaml with slash command.

Fixes #34956

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10316110580
Commit: 41a74c7
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Fri, 09 Aug 2024 08:43:58 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Actions workflow to disable Yarn cache restoration, which may affect build times.
    • Modified Cypress test specifications to focus on the Fork application instead of templates, refining test execution priorities.
    • Enhanced the GitHub Actions workflow with a new input parameter, run_count, improving configurability and responsiveness to events.

Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Walkthrough

The recent updates to the GitHub Actions workflows significantly enhance configurability by introducing a new input parameter, run_count, allowing for dynamic execution based on external inputs. Additionally, the focus of a Cypress test specification has shifted to prioritize the Fork application, while the restoration of the Yarn cache has been disabled, which may affect build efficiency. These changes reflect a strategic reorganization of testing priorities while retaining the overall structure of the workflows.

Changes

File Change Summary
.github/workflows/ci-test-limited-with-count.yml Disabled Yarn cache restoration, which may lead to longer build times and dependency resolution issues.
app/client/cypress/limited-tests.txt Changed test specification path from a template-related test to one focused on the Fork application.
.github/workflows/build-client-server-count.yml Added a new input parameter run_count from GitHub event inputs, enhancing workflow configurability.

Sequence Diagram(s)

sequenceDiagram
    participant CI as CI Workflow
    participant Yarn as Yarn Cache
    participant Cypress as Cypress Test Suite

    CI->>Yarn: Check cache restoration
    alt Cache Restored
        Yarn-->>CI: Restore dependencies
    else Cache Not Restored
        CI->>Cypress: Install dependencies directly
    end
    CI->>Cypress: Run limited tests
Loading

Poem

In the realm of code, where changes unfold,
A cache now rests, its tales left untold.
From templates to Fork, our path we refine,
As tests find new purpose, their focus align.
Here’s to the workflow, agile and spry,
In the dance of CI, let creativity fly! ✨


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

Copy link

github-actions bot commented Aug 7, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5acc392 and 8dc6d49.

Files selected for processing (2)
  • .github/workflows/ci-test-limited-with-count.yml (1 hunks)
  • app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/ci-test-limited-with-count.yml
  • app/client/cypress/limited-tests.txt

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

Copy link

github-actions bot commented Aug 7, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8dc6d49 and 834b464.

Files selected for processing (1)
  • .github/workflows/build-client-server-count.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build-client-server-count.yml (1)

134-134: Verify the correct integration of the run_count parameter.

The addition of the run_count parameter appears to be correct. Ensure that the parameter is correctly referenced in the downstream workflow and does not introduce any syntax errors or logical issues.

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

Copy link

github-actions bot commented Aug 7, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 834b464 and da557e8.

Files selected for processing (1)
  • .github/workflows/build-client-server-count.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-client-server-count.yml

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

Copy link

github-actions bot commented Aug 7, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between da557e8 and 82bf829.

Files selected for processing (1)
  • .github/workflows/build-client-server-count.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-client-server-count.yml

@sagar-qa007 sagar-qa007 changed the title DO NOT Merge Testing pipeline test: Testing pipeline with build yaml and run_count Aug 7, 2024
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Aug 7, 2024
@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Aug 7, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 82bf829 and e540fc7.

Files selected for processing (1)
  • .github/workflows/build-client-server-count.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-client-server-count.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e540fc7 and 41a74c7.

Files selected for processing (1)
  • .github/workflows/build-client-server-count.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-client-server-count.yml

@ApekshaBhosale ApekshaBhosale removed the ok-to-test Required label for CI label Aug 9, 2024
@ApekshaBhosale ApekshaBhosale added the ok-to-test Required label for CI label Aug 9, 2024
@sagar-qa007 sagar-qa007 merged commit 92b8f81 into release Aug 9, 2024
42 checks passed
@sagar-qa007 sagar-qa007 deleted the fix/runforkwithwrkflw branch August 9, 2024 08:55
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

1 similar comment
@sagar-qa007
Copy link
Contributor Author

/ci-test-limit-count run_count=3

Copy link

@sagar-qa007
Copy link
Contributor Author

/ci-test-limit

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants