fix: Release blocker - ads migration #35285
Conversation
WalkthroughThe recent changes significantly improve the notification system across various components in the application. The shift from the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
ADS Components
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
app/client/packages/design-system/ads-old/src/index.ts (1)
Verify the impact of removing the
Toastcomponent.The
Toastcomponent is still being imported in the following files and needs to be updated to use the new notification system to avoid broken imports:
app/client/src/index.tsxapp/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsxPlease update these imports accordingly.
Analysis chain
Line range hint
1-1:
Verify the impact of removing theToastcomponent.Ensure that all imports of the
Toastcomponent are updated to use the new notification system to avoid broken imports.
Let's correct the regex pattern and include TypeScript files in our search to ensure we capture all potential imports of the
Toastcomponent.
Let's update our script to correctly search for the
Toastcomponent imports in.ts,.tsx, and.jsfiles.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that no other parts of the codebase import the removed `Toast` component. # Test: Search for imports of the `Toast` component. Expect: No occurrences. rg --type js 'import { Toast }'Length of output: 141
Script:
#!/bin/bash # Description: Verify that no other parts of the codebase import the removed `Toast` component. # Test: Search for imports of the `Toast` component in both JavaScript and TypeScript files. Expect: No occurrences. rg --type-add 'ts:*.ts' --type-add 'tsx:*.tsx' --type-add 'js:*.js' --type ts,tsx,js 'import\s+\{\s+Toast\s+\}'Length of output: 147
Script:
#!/bin/bash # Description: Verify that no other parts of the codebase import the removed `Toast` component. # Test: Search for imports of the `Toast` component in .ts, .tsx, and .js files. Expect: No occurrences. rg 'import\s+\{\s+Toast\s+\}' --glob '*.ts' --glob '*.tsx' --glob '*.js'Length of output: 242
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- app/client/packages/design-system/ads-old/src/FilePickerV2/index.tsx (3 hunks)
- app/client/packages/design-system/ads-old/src/index.ts (1 hunks)
- app/client/packages/design-system/widgets-old/src/index.ts (1 hunks)
- app/client/src/index.tsx (1 hunks)
- app/client/src/sagas/OneClickBindingSaga.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- app/client/packages/design-system/widgets-old/src/index.ts
- app/client/src/index.tsx
Additional comments not posted (5)
app/client/src/sagas/OneClickBindingSaga.ts (3)
51-51: Good job importing the newtoastfunction.This import aligns with the new notification system.
378-380: Excellent update to error notifications.The change from
Toaster.showtotoast.showwith the updated parameters improves consistency and clarity.
388-397: Well done updating success notifications.The use of
toast.showwith the new parameters (hideProgressBar,kind,autoClose) aligns with the updated notification system and simplifies the code.app/client/packages/design-system/ads-old/src/FilePickerV2/index.tsx (2)
10-10: Great update to import thetoastfunction.This import aligns with the new notification system.
353-354: Nice work updating the file size error notification.The change from
Toaster.showtotoast.showwith the updated parameters improves consistency and clarity.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
app/client/packages/design-system/ads-old/src/AppIcon/index.tsx (1)
429-429: Avoid usinganytype foronClickproperty.Changing the type from
unknowntoanycan lead to loss of type safety. Consider using a more specific type such asReact.MouseEventorReact.SyntheticEventto maintain type safety and clarity.- onClick?: (e: any) => void; + onClick?: (e: React.MouseEvent<HTMLAnchorElement> | React.SyntheticEvent) => void;
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/packages/design-system/ads-old/src/AppIcon/index.tsx (1 hunks)
Additional comments not posted (1)
app/client/packages/design-system/ads-old/src/AppIcon/index.tsx (1)
434-435: Verify the impact of the simplifieduseMemologic.The new logic simplifies the condition but may affect size interpretation if
props.sizecan be falsy values. Ensure that this change does not introduce unintended behavior.
Description
This PR addresses below release blockers
Fixes #35274
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10159241062
Commit: b772f12
Cypress dashboard.
Tags:
@tag.AllSpec:
Tue, 30 Jul 2024 09:45:47 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes
Chores