-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated new tab ui with search and load more #34981
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6ddf1c8
feat: Updated new tab ui with search and load more
albinAppsmith 6c59766
fix: title for module fixed
albinAppsmith be7c2ed
fix: updated string to messages
albinAppsmith a006f80
feat: created constant for editor tab height
albinAppsmith 15479d0
feat: Editor tab height constant
albinAppsmith 5faa22a
fix: fuzy search function fixes
albinAppsmith 3f971f7
fix: optmised items
albinAppsmith 6c3f2ed
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 536eeec
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith 2d37c01
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
albinAppsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
app/client/src/pages/Editor/IDE/EditorPane/components/EmptySearchResult.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from "react"; | ||
import { Text } from "design-system"; | ||
import { EDITOR_PANE_TEXTS, createMessage } from "@appsmith/constants/messages"; | ||
|
||
const EmptySearchResult = ({ type }: { type: string }) => { | ||
return ( | ||
<Text | ||
className="font-normal text-center" | ||
color="var(--ads-v2-color-fg-muted)" | ||
kind="body-s" | ||
> | ||
{createMessage(EDITOR_PANE_TEXTS.empty_search_result, type)} | ||
</Text> | ||
); | ||
}; | ||
|
||
export { EmptySearchResult }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using template literals for consistency and future extensibility.
The functions returning strings in this file use regular strings. For consistency with other parts of the codebase that might use template literals and to facilitate easier modifications in the future (like introducing variables into the strings), consider using template literals here as well.
Committable suggestion