Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix extra space at the end of multi-line input widget #33099 #33886

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented May 31, 2024

Fixes #33099

/ok-to-test tags="@tag.Anvil"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9318021083
Commit: 5f1ea63
Cypress dashboard url: Click here!

Copy link
Contributor

coderabbitai bot commented May 31, 2024

Walkthrough

Walkthrough

The recent changes address a bug related to the textarea height in the multi-line input widget. Specifically, the height calculation was adjusted by adding 1px to mitigate a browser scrollbar issue. Additionally, the box-sizing property for text input styling was changed from content-box to border-box to resolve layout inconsistencies.

Changes

Files/Paths Change Summary
.../design-system/headless/src/components/TextArea/src/TextArea.tsx Adjusted the textarea height calculation by adding 1px to fix a browser scrollbar issue.
.../design-system/widgets/src/styles/src/text-input.module.css Changed box-sizing property from content-box to border-box for text input styling.

Assessment against linked issues

Objective Addressed Explanation
Fix the extra space at the end of the multi-line input widget (Issue #33099)
Ensure the bottom gap/space is lesser than the line height in the multi-line input widget (#33099)

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ddd5571 and 5f1ea63.

Files selected for processing (1)
  • app/client/packages/design-system/headless/src/components/TextArea/src/TextArea.tsx (1 hunks)
Files not reviewed due to errors (1)
  • app/client/packages/design-system/headless/src/components/TextArea/src/TextArea.tsx (no review received)
Additional context used
Biome
app/client/packages/design-system/headless/src/components/TextArea/src/TextArea.tsx

[error] 23-23: Avoid redundant Boolean call


[error] 23-23: Avoid redundant Boolean call


[error] 35-35: This hook specifies more dependencies than necessary: inputRef


[error] 53-53: Use Number.parseFloat instead of the equivalent global.


[error] 54-54: Use Number.parseFloat instead of the equivalent global.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Anvil Pod Issue related to Anvil project Bug Something isn't working Medium Issues that frustrate users due to poor UX WDS team skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Bug Something isn't working labels May 31, 2024
@github-actions github-actions bot added the Bug Something isn't working label May 31, 2024
paddingTop -
paddingBottom +
// Also, adding 1px to fix a bug in browser where there is a scrolllbar on certain heights
1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without +1, I see this bug

CleanShot.2024-05-31.at.16.34.35.mp4

@KelvinOm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsartisan This works without adding 1. Please check it. It looks like the calculations were simply wrong before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, without 1, it does not work.
I have these settings on my mac.
CleanShot 2024-06-03 at 15 23 18@2x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@jsartisan jsartisan requested a review from KelvinOm May 31, 2024 11:05
@jsartisan jsartisan added the ok-to-test Required label for CI label May 31, 2024
@github-actions github-actions bot removed the Bug Something isn't working label May 31, 2024
@jsartisan jsartisan enabled auto-merge (squash) May 31, 2024 12:19
@jsartisan jsartisan merged commit d712c77 into release Jun 3, 2024
49 of 50 checks passed
@jsartisan jsartisan deleted the fix/textarea-height branch June 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Medium Issues that frustrate users due to poor UX ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog WDS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Extra space at the end of multi-line input widget
2 participants