Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed spring security and redis traces #24758

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

nidhi-nair
Copy link
Contributor

Description

Adds a filter for http endpoints that are recorded in our traces. We have discarded the actuator endpoints since we don't care about their metrics.

We have also filtered spans to only contain the ones that we have manually declared across the project. All spans need to use the appsmith. prefix to pass through this filter. This change discards spring security and redis spans as of today.

Fixes #24757

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

@nidhi-nair nidhi-nair requested a review from sharat87 June 22, 2023 13:33
@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code DevOps Pod Issues related to devops Observability Issues related to observability on the Appsmith instance Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jun 22, 2023
Copy link
Member

@sharat87 sharat87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change request.

@nidhi-nair nidhi-nair requested a review from sharat87 June 27, 2023 04:54
@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform DevOps Pod Issues related to devops Observability Issues related to observability on the Appsmith instance Query & JS Pod Issues related to the query & JS Pod skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Task]: Remove unnecessary traces and spans from observability stack
2 participants