Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Currency and Country Code change #38091

Closed
jsartisan opened this issue Dec 11, 2024 · 0 comments · Fixed by #38141
Closed

Allow Currency and Country Code change #38091

jsartisan opened this issue Dec 11, 2024 · 0 comments · Fixed by #38141
Assignees
Labels
Anvil Pod Issue related to Anvil project Task A simple Todo

Comments

@jsartisan
Copy link
Contributor

jsartisan commented Dec 11, 2024

No description provided.

@jsartisan jsartisan added the Anvil Pod Issue related to Anvil project label Dec 11, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Dec 11, 2024
@jsartisan jsartisan self-assigned this Dec 11, 2024
@jsartisan jsartisan changed the title WDS Widgets bugs Allow Currency and Country Code change Dec 16, 2024
jsartisan added a commit that referenced this issue Dec 19, 2024
![CleanShot 2024-12-16 at 16 42
37](https://github.com/user-attachments/assets/1b59a2f9-d8d1-4fa9-8827-493622088e56)

![CleanShot 2024-12-16 at 16 43
12](https://github.com/user-attachments/assets/b8d29bba-55c5-42ec-8352-fb8b374ef8d2)

Fixes #38091 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Added new props for enhanced styling and functionality in various
components, including `className` and `maxHeight`.
- Introduced dropdown menus for currency and ISD code selection in the
CurrencyInput and PhoneInput components.
- New story added for the `TextField` component showcasing prefix and
suffix usage.
- Added a custom hook `useRootContainer` for better theme provider
management.

- **Bug Fixes**
- Improved conditional rendering for input elements based on prop
values.

- **Style**
- Significant updates to CSS for input and select components, enhancing
layout and visual feedback.
- New CSS classes added for ComboBox and styling adjustments for
existing classes.
	- Enhanced styling for the ComboBox popover and other components.
- New CSS rules for currency and dial code options in respective
widgets.

- **Documentation**
- Updated property configurations for widgets to include new toggle
options for currency and dial code changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12391730072>
> Commit: b8bb738
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12391730072&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Wed, 18 Dec 2024 11:33:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
![CleanShot 2024-12-16 at 16 42
37](https://github.com/user-attachments/assets/1b59a2f9-d8d1-4fa9-8827-493622088e56)

![CleanShot 2024-12-16 at 16 43
12](https://github.com/user-attachments/assets/b8d29bba-55c5-42ec-8352-fb8b374ef8d2)

Fixes #38091 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Added new props for enhanced styling and functionality in various
components, including `className` and `maxHeight`.
- Introduced dropdown menus for currency and ISD code selection in the
CurrencyInput and PhoneInput components.
- New story added for the `TextField` component showcasing prefix and
suffix usage.
- Added a custom hook `useRootContainer` for better theme provider
management.

- **Bug Fixes**
- Improved conditional rendering for input elements based on prop
values.

- **Style**
- Significant updates to CSS for input and select components, enhancing
layout and visual feedback.
- New CSS classes added for ComboBox and styling adjustments for
existing classes.
	- Enhanced styling for the ComboBox popover and other components.
- New CSS rules for currency and dial code options in respective
widgets.

- **Documentation**
- Updated property configurations for widgets to include new toggle
options for currency and dial code changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12391730072>
> Commit: b8bb738
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12391730072&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Wed, 18 Dec 2024 11:33:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Task A simple Todo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants