Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Git mod - Components - Quick action bar #37801

Closed
brayn003 opened this issue Nov 29, 2024 · 1 comment · Fixed by #37912
Closed

[Task] Git mod - Components - Quick action bar #37801

brayn003 opened this issue Nov 29, 2024 · 1 comment · Fixed by #37912
Assignees
@ashit-rath
Labels
Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo

Comments

@brayn003
Copy link
Contributor

brayn003 commented Nov 29, 2024 •
edited
Loading

The task entails the following subtasks -
[] Create/Migrate component for Git Quick Action Bar
[] Create/Migrate components for Git Connect Btn
[] Create/Migrate components for Git Action Icons
[] Create/Migrate components for Git Autocommit Progress

Instructions:

  1. Components must not be passing props to each other (not dependent on each other)
  2. Components should assume external data from props (not dependent on store or context)
  3. Please add jest test cases too
@brayn003 brayn003 added the Packages Pod issues that belong to the packages pod label Nov 29, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 29, 2024
@github-actions github-actions bot added the Packages & Git Pod All issues belonging to Packages and Git label Nov 29, 2024
@brayn003
Copy link
Contributor Author

Component hierarchy reference - https://miro.com/app/board/uXjVL-Nij1k=/?share_link_id=399571906178

@ashit-rath ashit-rath mentioned this issue Dec 3, 2024
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Dec 9, 2024
@ashit-rath
chore: Git mod - quick action bar control (appsmithorg#37912)
b485429 
## Description
Git modularisation - Bottom quick action bar control

Note to Reviewer: 
- The `BranchButton` component is commented out right now since it was
not part of the modularisation
- I have modified the logic for `AutocommitStatusbar` as I found there
was a bug with the percentage calculation, please review


Fixes appsmithorg#37801 

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12153277180>
> Commit: e9e901f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12153277180&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Wed, 04 Dec 2024 06:02:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced `AutocommitStatusbar` component to display autocommit
progress.
	- Added `ConnectButton` for initiating Git connection actions.
	- Launched `QuickActionButton` for customizable Git action buttons.
- Implemented `QuickActions` component for managing various Git
operations.

- **Tests**
- Comprehensive test suites added for `AutocommitStatusbar`,
`ConnectButton`, `QuickActionButton`, and `QuickActions` components to
ensure functionality and reliability.
- Enhanced test coverage for helper functions managing Git button
statuses and string manipulation.

These updates enhance user interaction with Git functionalities within
the application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashit-rath ashit-rath

Labels
Packages & Git Pod All issues belonging to Packages and Git Packages Pod issues that belong to the packages pod Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Git mod - quick action bar control appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @brayn003 @ashit-rath